Last modified: 2013-10-29 12:14:17 UTC
https://integration.wikimedia.org/ci/job/mwext-VisualEditor-phpcs-HEAD/1561/console is a bogus failure. The error messages are: 14:41:05 FILE: ...orkspace/mwext-VisualEditor-phpcs-HEAD/maintenance/makeStaticLoader.php 14:41:05 -------------------------------------------------------------------------------- 14:41:05 FOUND 2 ERROR(S) AFFECTING 2 LINE(S) 14:41:05 -------------------------------------------------------------------------------- 14:41:05 78 | ERROR | Expected 1 space before "?"; 3 found 14:41:05 | | (Squiz.WhiteSpace.OperatorSpacing.SpacingBefore) 14:41:05 80 | ERROR | Expected 1 space before ":"; 3 found 14:41:05 | | (Squiz.WhiteSpace.OperatorSpacing.SpacingBefore) 14:41:05 -------------------------------------------------------------------------------- The source code doesn't have 3 spaces before the ?, only a bunch of tabs), but it does have a comment on the preceding line each time. Maybe that's what's confusing phpcs?
Filing this because it will eventually block https://gerrit.wikimedia.org/r/#/c/88896/ once that commit has been cleaned up and reviewed.
Looking at the code, the phpcs failure seemed correct, the ternary operators should be at end of line.
