Last modified: 2013-10-15 16:47:29 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T57632, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 55632 - UDP packet flooding possible with maintenance/purgeChangedPages.php
UDP packet flooding possible with maintenance/purgeChangedPages.php
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Maintenance scripts (Other open bugs)
1.22.0
All All
: High normal (vote)
: ---
Assigned To: Bryan Davis
:
Depends on:
Blocks: 54647
  Show dependency treegraph
 
Reported: 2013-10-11 17:44 UTC by Bryan Davis
Modified: 2013-10-15 16:47 UTC (History)
0 users

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Bryan Davis 2013-10-11 17:44:00 UTC
Mark has pointed out that the new maintenance/purgeChangedPages.php script could saturate packet buffers in routers and switches if it sends a very large number of UDP packets in a short period of time. The consequence of this would be that some unknown number of packets are silently discarded due to buffer overflow.

A suggested solution is to insert a small artificial delay before sending each packet. Brandon suggested that a 10ms should be more than enough to prevent buffer overflows. With that rate limit in place we would effectively throttle the HTCP packet output to 100/s (360,000/hr). It's estimated that a 10K-item purge would take ~17 minutes of wall clock time to complete and a 150K list would take 25 minutes .
Comment 1 Bryan Davis 2013-10-11 17:50:14 UTC
Further discussion with Brandon and Mark sets a rate of 200/s (5ms delay) as also acceptable.
Comment 2 Gerrit Notification Bot 2013-10-11 19:48:56 UTC
Change 89325 had a related patch set uploaded by BryanDavis:
Add HTCP rate limiting to SquidUpdate

https://gerrit.wikimedia.org/r/89325
Comment 3 Gerrit Notification Bot 2013-10-15 15:41:40 UTC
Change 89842 had a related patch set uploaded by BryanDavis:
Add configurable delay between purgeChangedPages batches

https://gerrit.wikimedia.org/r/89842
Comment 4 Gerrit Notification Bot 2013-10-15 15:43:57 UTC
Change 89844 had a related patch set uploaded by BryanDavis:
Add configurable delay between purgeChangedPages batches

https://gerrit.wikimedia.org/r/89844
Comment 5 Gerrit Notification Bot 2013-10-15 15:46:44 UTC
Change 89325 merged by jenkins-bot:
Add configurable delay between purgeChangedPages batches

https://gerrit.wikimedia.org/r/89325
Comment 6 Gerrit Notification Bot 2013-10-15 15:54:55 UTC
Change 89842 merged by jenkins-bot:
Add configurable delay between purgeChangedPages batches

https://gerrit.wikimedia.org/r/89842
Comment 7 Gerrit Notification Bot 2013-10-15 15:58:23 UTC
Change 89844 merged by jenkins-bot:
Add configurable delay between purgeChangedPages batches

https://gerrit.wikimedia.org/r/89844
Comment 8 Bryan Davis 2013-10-15 16:47:29 UTC
Patch is merged, backported and pushed to cluster.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links