Last modified: 2014-10-15 16:36:46 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T57681, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 55681 - Line breaks missing after salutations and before signature lines
Line breaks missing after salutations and before signature lines
Status: NEW
Product: Wikimedia
Classification: Unclassified
OTRS (Other open bugs)
wmf-deployment
All All
: Normal minor (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-10-13 22:46 UTC by Ryan (Rjd0060)
Modified: 2014-10-15 16:36 UTC (History)
8 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Screenshot of bug (9.39 KB, image/png)
2013-10-13 22:46 UTC, Ryan (Rjd0060)
Details

Description Ryan (Rjd0060) 2013-10-13 22:46:52 UTC
Created attachment 13479 [details]
Screenshot of bug

When replying to a ticket, there used to be line breaks after the "salutation" (typically the 'Dear X,' part) and then another before the signature line ( typically beginning with "Yours sincerely,").

See attached screenshot for visual explanation.  This bug began with the upgrade to 3.2.  There may be an internal configuration setting, but I'm not seeing it.
Comment 1 Patrik (pajz) 2013-11-17 19:32:46 UTC
FYI, I have reported this upstream at http://bugs.otrs.org/show_bug.cgi?id=9951.

Some additional info: It was attempted to fix the issue in our installation through a package (it's still installed -> "WikimediaEnableMultiLines" in the package manager) shortly after the upgrade. Unfortunately, that fix doesn't work. Might be a starting point for tackling this bug if necessary.
Comment 2 Ryan (Rjd0060) 2013-11-17 19:40:40 UTC
I wonder if there is any way to insert line breaks in the salutation and signatures themselves?
Comment 3 Patrik (pajz) 2013-11-17 20:10:28 UTC
If I remember correctly Marcel concluded based on the code that whitespace characters are scrapped from the beginning/end of the salutations/signatures. I tried several variants, including the direct insertion of the corresponding unicode characters and combinations of different characters (e.g. newline and emptyspace), but as soon as you save it, they disappear from the textbox. If someone has an idea how to get around it, your ideas are very much welcome.
Comment 4 Douglas Gardner 2014-06-09 18:51:59 UTC
This appears to be fixed upstream.
Comment 5 Ryan (Rjd0060) 2014-08-13 20:26:05 UTC
Any update?  Can we get the fix applied on our install?
Comment 6 Yellowcard 2014-08-14 19:11:01 UTC
+1. This bug is actually annoying. As a fix seems available, I'd really appreciate it to be deployed.
Comment 7 Patrik (pajz) 2014-08-14 19:14:03 UTC
Just note the upstream fix is implemented in 3.3 (we're currently on 3.2).
Comment 8 Félix M. (elfix) 2014-08-15 13:47:46 UTC
It seems to be this fix: <https://github.com/OTRS/otrs/pull/44>. Can it be patched if it is deemed preferable not to upgrade to 3.3?
Comment 9 Alex Monk 2014-10-15 16:36:46 UTC
See bug 63685 comment 5

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links