Last modified: 2014-06-17 17:04:13 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T57688, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 55688 - Create a Bootstrap 3 compliant version of Chameleon that works with the latest stable version of MW
Create a Bootstrap 3 compliant version of Chameleon that works with the lates...
Status: RESOLVED WONTFIX
Product: MediaWiki skins
Classification: Unclassified
Chameleon (Other open bugs)
unspecified
All All
: Lowest enhancement
: ---
Assigned To: s7eph4n
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-10-14 05:31 UTC by Huji
Modified: 2014-06-17 17:04 UTC (History)
0 users

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Huji 2013-10-14 05:31:37 UTC
Currently, Chameleon skin does support Bootstrap 3, but only with MW 1.22alpha (because of its dependencies). Please consider creating a version of the skin that works with 1.21 stable.
Comment 1 s7eph4n 2013-10-14 07:05:00 UTC
Does it work, if you install the Less extension? If not, what is the error?
Comment 2 Huji 2013-10-14 16:11:04 UTC
PHP Fatal error:  Call to undefined method skins\\chameleon\\ChameleonTemplate::get() in /var/www/wiki2/skins/chameleon/components/MainContent.php on line 49

I get that even with the oldest revision that supports Bootstrap 3 (8e757951fba2a00f29fc9603d5ac191ddb95caab).

Note that part of the problem is that Bootstrap extension v 0.1 is only compatible with MW 1.22+ so I had to install use revision 4d32f1440be9c3fbaac5da3f57907c6bcb0c629a of that extension instead.
Comment 3 Huji 2013-10-14 16:26:42 UTC
The problem is due to the addition of function get() to the includes/SkinTemplate.php in 1.22 and reliance of Chameleon on this function.
Comment 4 s7eph4n 2013-10-14 16:29:30 UTC
It would be better to use the latest version of Bootstrap and comment out the version check at the beginning of Bootstrap.php.

The get method is new in 1.22. To take care of it replace every $skintemplate->get( 'something' ) in MainContent.php by $skintemplate->data[ 'something' ].
Comment 5 Huji 2013-10-14 16:46:50 UTC
With that, I get:

PHP Fatal error:  Call to undefined method ResourceLoader::getLessCompiler()
Comment 6 s7eph4n 2013-10-14 18:18:57 UTC
Replace 

 $compiler = ResourceLoader::getLessCompiler();

in ResourceLoaderBootstrapModule by 

 $compiler = new \lessc();
Comment 7 Huji 2013-10-15 00:30:58 UTC
Doesn't help much. Now I get this error (and many more like this one):

File does not exist: /var/www/wiki2/responsive-utilities
Comment 8 s7eph4n 2013-10-15 06:46:59 UTC
Ok, then I give up for now. I had hoped it would be as easy as using the lessphp compiler of the Less extension instead of the built-in one in 1.22.
Comment 9 Huji 2013-10-15 11:24:40 UTC
Exactly. That is why I opened this bug. It would be great if you could create a tagged version of these extensions and skin, that works with the latest stable release of MW.
Comment 10 s7eph4n 2014-03-31 09:27:35 UTC
Closing as obsolete. 1.22 is released as stable since 2013-12-06.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links