Last modified: 2014-05-08 10:12:01 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T57694, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 55694 - LQT 2.0 - Cannot read property 'token' of undefined
LQT 2.0 - Cannot read property 'token' of undefined
Status: NEW
Product: MediaWiki extensions
Classification: Unclassified
LiquidThreads (Other open bugs)
REL1_21-branch
All Linux
: High major (vote)
: MW 1.21 version
Assigned To: Nobody - You can work on this!
https://www.mediawiki.org/wiki/Extens...
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-10-14 11:25 UTC by Volodya
Modified: 2014-05-08 10:12 UTC (History)
7 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---
mah: Backport_to_Stable-


Attachments

Description Volodya 2013-10-14 11:25:48 UTC
Hello,

After upgrading MediaWiki i have began to encounter the following error when creating or replying to a thread on LQT 2.0 with javascript enabled:

Uncaught TypeError: Cannot read property 'token' of undefined

It happens on at the following execution.

var token = data.threadaction.token;

I've looked at what 'data' is, and it's:
data -> Object
error -> Object
code = "notoken"
info = "The token parameter must be set"
...
There are some __proto things there too, let me know if you need them

Server:
  MediaWiki 1.21.2

Client:
  Chromium	28.0.1500.71 (Developer Build 28.0.1500.71-0ubuntu1.12.04.1)
  Ubuntu 12.04
Comment 1 Andre Klapper 2013-10-14 15:48:29 UTC
Is there a public wiki URL where this can be tested/seen?
Comment 2 Volodya 2013-10-14 18:00:06 UTC
No, i've now purposefully broken Javascript in LQT. I'll think of how i can make it visible to help resolve this but, but yet not break the site in the process.
Comment 3 Jesús Martínez Novo (Ciencia Al Poder) 2013-12-06 17:40:53 UTC
I can consistently reproduce this bug downloading latest 1.21 version (1.21.3) and latest LQT matching 1.21 version (1e65894) from mediawiki.org

When creating a new thread, it sends a POST to api.php with those parameters:

 action=threadaction&gettoken=gettoken&format=json

And the response is:

 {"error":{"code":"notoken","info":"The token parameter must be set"}}
Comment 4 Jesús Martínez Novo (Ciencia Al Poder) 2013-12-06 18:32:59 UTC
The issue solves for me when retrieving LQT version at commit cf2ba86af92fc63f9e5f272cbe06b828bbb2072f, which is the merge of Gerrit change #58817, follow up of Gerrit change #50857

Someone needs to backport these into 1.21 release branch, or forward 1.21 branch until that commit.

I haven't tested all LQT features at this point, so I'm not sure if anything else is badly broken. Although it *requires* Extension:WikiEditor to be installed, otherwise JavaScript throws an error about unknown ext.wikieditor module.
Comment 5 Andre Klapper 2013-12-09 15:19:09 UTC
[Setting backport flag to ? as per comment 4]

Krenair: Any plans to backport this to REL_1_21?
Comment 6 Mark A. Hershberger 2014-05-08 10:12:01 UTC
Cherry picking doesn't work.  It seems clear that this isn't urgently needed.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links