Last modified: 2014-06-28 20:58:52 UTC
Created attachment 13494 [details] ProveIt floats over Save The ProveIt tool floats on top of the wikitext editor controls and makes the test fail like so attempting to click 'Save page': $ bundle exec cucumber features/page.feature:38 Using the default profile... ....F------ (::) failed steps (::) unknown error: Element is not clickable at point (259, 764). Other element would receive the click: <div id="tabs" class="ui-tabs ui-widget ui-widget-content ui-corner-all">...</div> (Session info: chrome=30.0.1599.66) (Driver info: chromedriver=2.3,platform=Linux 3.2.0-54-generic x86_64) (Selenium::WebDriver::Error::UnknownError) ./features/step_definitions/page_steps.rb:9:in `/^I click Save page button$/' ./features/step_definitions/page_steps.rb:51:in `/^I create the page to be moved$/' features/page.feature:38:in `And I create the page to be moved' Failing Scenarios: cucumber features/page.feature:35 # Scenario: Move existing page dialog 1 scenario (1 failed) 10 steps (1 failed, 6 skipped, 3 passed) 0m36.042s
What is the best possible solution for this? Is it to implement something like Page Down keypress before clicking the save button (user would probably scroll up-down to see where are the buttons) or something else?
We could enable the gadget in a "before" hook before each ProveIt scenario and disable it an "after" hook after each scenario, so the gadget is active only when the tests for it are running.
That screenshot doesn't show ProveIt blocking the save button. It could be a bug in the test, or perhaps it needs a moment to position ProveIt before you do the save.
Created attachment 13521 [details] ProveIt really floats over Save This is arguably a bug in ChromeDriver. This part of the WebDriver W3C standard is being discussed as we speak, actually. Firefox is liberal about what can be clicked, Chrome is not.
(In reply to comment #1) > What is the best possible solution for this? > Is it to implement something like Page Down keypress before clicking the save > button (user would probably scroll up-down to see where are the buttons) or > something else? I think I would like to just run the test for Firefox and not for Chrome. (And see what happens with Internet Explorer)
Change 91180 had a related patch set uploaded by Cmcmahon: don't run the ProveIt test for Chrome because of Bug 55751 https://gerrit.wikimedia.org/r/91180
Change 91180 abandoned by Cmcmahon: don't run the ProveIt test for Chrome because of Bug 55751 Reason: mistake https://gerrit.wikimedia.org/r/91180
Change 91182 had a related patch set uploaded by Cmcmahon: ProveIt gadget causes Page test to fail in Chrome Bug 55751 https://gerrit.wikimedia.org/r/91182
Change 91182 merged by Cmcmahon: ProveIt gadget causes Page test to fail in Chrome Bug 55751 https://gerrit.wikimedia.org/r/91182
Can this be closed now?
It hasn't been fixed, right? My understanding was just that you stopped running the tests for now. So how about just marking it lowest priority?
Closing since this seems to be fixed. Please reopen if the problem is not fixed.
I checked with Chris. They are still not running, and this is not fixed. Stopping them from running was just a workaround.
Chris, is this resolved now?
