Last modified: 2013-10-17 21:50:40 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T57763, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 55763 - Undefined variable: txt in RSSParser.php on line 376
Undefined variable: txt in RSSParser.php on line 376
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
RSS (Other open bugs)
unspecified
All All
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2013-10-15 21:46 UTC by Diederik van Liere
Modified: 2013-10-17 21:50 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Diederik van Liere 2013-10-15 21:46:20 UTC 
Heya,

I am trying to consume an atom feed, see https://www.mediawiki.org/wiki/User_talk:Drdee/RSS

but I get: 

Failed to load RSS feed from https://mingle.corp.wikimedia.org/projects/analytics/feeds/8z8k6vUfniLmWc2qGe6GMQsxBujvKRKuybLd8mdTbMFHwGfLH3oxK*MU0E8zM6go.atom: HTTP request timed out.

Is atom fully supported? It seems so but I am not quite sure.
Comment 1 T. Gries 2013-10-17 15:19:12 UTC 
set to normal.

These problems are all related to incorrect settings, or slow servers, not a "major" issue.
Comment 2 Diederik van Liere 2013-10-17 15:35:31 UTC 
Can you give some pointers on what the correct settings should be?
Comment 3 T. Gries 2013-10-17 15:38:57 UTC 
(In reply to comment #2)
> Can you give some pointers on what the correct settings should be?

RTFM.
Can you please wear your glasses and read the fine manual https://www.mediawiki.org/wiki/Extension:RSS#Configuration_settings ?

wgRSSFetchTimeout 	15 (since version 1.94)

5 (until version 1.93)
	read timeout in seconds
Comment 4 T. Gries 2013-10-17 15:40:15 UTC 
Bug reporters: please indicate the version info for

- MediaWiki core and
- Extension RSS

as printed on  your Special:Version page.
Comment 5 Diederik van Liere 2013-10-17 15:47:30 UTC 
Well obviously I read the manual -- the request times out immediately, it does not wait for 15 seconds.

Running MediaWiki 1.22wmf21 (7b496d2) and RSS feed (Version 2.23)
Comment 6 T. Gries 2013-10-17 15:52:42 UTC 
(In reply to comment #5)
> Well obviously I read the manual -- the request times out immediately, it
> does
> not wait for 15 seconds.
> 
> Running MediaWiki 1.22wmf21 (7b496d2) and RSS feed (Version 2.23)

Ok. 

First Aid:

- set $wgRSSUrlNumberOfAllowedRedirects to a relevant number like 3 or 4 (to allow that number of redirects !)

Does it work now ??

If not. check what your server sees when it tries to fetch the feed - this needs to be working without any problem. Check also your proxy settings, if your are behind a proxy, for example, in an enterprise intranet.

- open your server's console
- wget <your-rss-feed-url> (see above)
- report the output here (or send it to me by mail)
- check the $wgRSSUrlNumberOfAllowedRedirects setting (se E:RSS Manual page) !!!
Comment 7 Diederik van Liere 2013-10-17 20:48:58 UTC 
I installed the mediawiki-vagrant instance and I get the following stacktrace: 

Notice: Undefined variable: txt in /vagrant/mediawiki/extensions/RSS/RSSParser.php on line 376 Call Stack: 0.0197 656696 1. {main}() /vagrant/mediawiki/index.php:0 0.6761 13906624 2. MediaWiki->run() /vagrant/mediawiki/index.php:49 0.6763 13906624 3. MediaWiki->main() /vagrant/mediawiki/includes/Wiki.php:467 1.1157 21281160 4. MediaWiki->performRequest() /vagrant/mediawiki/includes/Wiki.php:602 1.1540 22248120 5. MediaWiki->performAction() /vagrant/mediawiki/includes/Wiki.php:312 1.1543 22249040 6. SubmitAction->show() /vagrant/mediawiki/includes/Wiki.php:448 1.1544 22249040 7. EditAction->show() /vagrant/mediawiki/includes/actions/EditAction.php:76 1.1874 23939304 8. EditPage->edit() /vagrant/mediawiki/includes/actions/EditAction.php:50 1.3062 25720000 9. EditPage->attemptSave() /vagrant/mediawiki/includes/EditPage.php:416 1.3063 25720160 10. EditPage->internalAttemptSave() /vagrant/mediawiki/includes/EditPage.php:1214 1.3873 26230800 11. Article->doEditContent() /vagrant/mediawiki/includes/EditPage.php:1755 1.3873 26231912 12. Article->__call() /vagrant/mediawiki/includes/Article.php:0 1.3873 26232544 13. call_user_func_array() /vagrant/mediawiki/includes/Article.php:2028 1.3873 26233672 14. WikiPage->doEditContent() /vagrant/mediawiki/includes/Article.php:0 1.4327 26695352 15. WikiPage->prepareContentForEdit() /vagrant/mediawiki/includes/WikiPage.php:1713 1.7446 32073424 16. WikitextContent->getParserOutput() /vagrant/mediawiki/includes/WikiPage.php:2025 1.7446 32073744 17. Parser->parse() /vagrant/mediawiki/includes/content/WikitextContent.php:300 1.7454 32082664 18. Parser->internalParse() /vagrant/mediawiki/includes/parser/Parser.php:391 1.7455 32083192 19. Parser->replaceVariables() /vagrant/mediawiki/includes/parser/Parser.php:1205 1.7462 32086784 20. PPFrame_DOM->expand() /vagrant/mediawiki/includes/parser/Parser.php:3146 1.7466 32100944 21. Parser->extensionSubstitution() /vagrant/mediawiki/includes/parser/Preprocessor_DOM.php:1181 1.7572 32104168 22. call_user_func_array() /vagrant/mediawiki/includes/parser/Parser.php:4017 1.7572 32104248 23. RSSHooks::renderRss() /vagrant/mediawiki/includes/parser/Parser.php:0 1.8261 33071344 24. RSSParser->renderFeed() /vagrant/mediawiki/extensions/RSS/RSSHooks.php:96 2.1177 33565632 25. RSSParser->renderItem() /vagrant/mediawiki/extensions/RSS/RSSParser.php:334 Warning: Cannot modify header information - headers already sent by (output started at /vagrant/mediawiki/extensions/RSS/RSSParser.php:376) in /vagrant/mediawiki/includes/WebResponse.php on line 38 Call Stack: 0.0197 656696 1. {main}() /vagrant/mediawiki/index.php:0 0.6761 13906624 2. MediaWiki->run() /vagrant/mediawiki/index.php:49 0.6763 13906624 3. MediaWiki->main() /vagrant/mediawiki/includes/Wiki.php:467 2.8951 34237800 4. OutputPage->output() /vagrant/mediawiki/includes/Wiki.php:609 2.8968 34246336 5. OutputPage->sendCacheControl() /vagrant/mediawiki/includes/OutputPage.php:2003 2.8972 34247384 6. WebResponse->header() /vagrant/mediawiki/includes/OutputPage.php:1903 2.8972 34247624 7. header() /vagrant/mediawiki/includes/WebResponse.php:38 Warning: Cannot modify header information - headers already sent by (output started at /vagrant/mediawiki/extensions/RSS/RSSParser.php:376) in /vagrant/mediawiki/includes/WebResponse.php on line 38 Call Stack: 0.0197 656696 1. {main}() /vagrant/mediawiki/index.php:0 0.6761 13906624 2. MediaWiki->run() /vagrant/mediawiki/index.php:49 0.6763 13906624 3. MediaWiki->main() /vagrant/mediawiki/includes/Wiki.php:467 2.8951 34237800 4. OutputPage->output() /vagrant/mediawiki/includes/Wiki.php:609 2.8968 34246336 5. OutputPage->sendCacheControl() /vagrant/mediawiki/includes/OutputPage.php:2003 2.8993 34247392 6. WebResponse->header() /vagrant/mediawiki/includes/OutputPage.php:1938 2.8993 34247632 7. header() /vagrant/mediawiki/includes/WebResponse.php:38 Warning: Cannot modify header information - headers already sent by (output started at /vagrant/mediawiki/extensions/RSS/RSSParser.php:376) in /vagrant/mediawiki/includes/WebResponse.php on line 38 Call Stack: 0.0197 656696 1. {main}() /vagrant/mediawiki/index.php:0 0.6761 13906624 2. MediaWiki->run() /vagrant/mediawiki/index.php:49 0.6763 13906624 3. MediaWiki->main() /vagrant/mediawiki/includes/Wiki.php:467 2.8951 34237800 4. OutputPage->output() /vagrant/mediawiki/includes/Wiki.php:609 2.8968 34246336 5. OutputPage->sendCacheControl() /vagrant/mediawiki/includes/OutputPage.php:2003 2.8995 34247408 6. WebResponse->header() /vagrant/mediawiki/includes/OutputPage.php:1939 2.8995 34247648 7. header() /vagrant/mediawiki/includes/WebResponse.php:38 Warning: Cannot modify header information - headers already sent by (output started at /vagrant/mediawiki/extensions/RSS/RSSParser.php:376) in /vagrant/mediawiki/includes/WebResponse.php on line 38 Call Stack: 0.0197 656696 1. {main}() /vagrant/mediawiki/index.php:0 0.6761 13906624 2. MediaWiki->run() /vagrant/mediawiki/index.php:49 0.6763 13906624 3. MediaWiki->main() /vagrant/mediawiki/includes/Wiki.php:467 2.8951 34237800 4. OutputPage->output() /vagrant/mediawiki/includes/Wiki.php:609 2.8997 34247392 5. WebResponse->header() /vagrant/mediawiki/includes/OutputPage.php:2005 2.8997 34247632 6. header() /vagrant/mediawiki/includes/WebResponse.php:38 Warning: Cannot modify header information - headers already sent by (output started at /vagrant/mediawiki/extensions/RSS/RSSParser.php:376) in /vagrant/mediawiki/includes/WebResponse.php on line 38 Call Stack: 0.0197 656696 1. {main}() /vagrant/mediawiki/index.php:0 0.6761 13906624 2. MediaWiki->run() /vagrant/mediawiki/index.php:49 0.6763 13906624 3. MediaWiki->main() /vagrant/mediawiki/includes/Wiki.php:467 2.8951 34237800 4. OutputPage->output() /vagrant/mediawiki/includes/Wiki.php:609 2.8999 34247400 5. WebResponse->header() /vagrant/mediawiki/includes/OutputPage.php:2012 2.8999 34247640 6. header() /vagrant/mediawiki/includes/WebResponse.php:38

This is using RSS feed (Version 2.23)	(41f37e7)
19:29, 15 October 2013

I am trying to read https://mingle.corp.wikimedia.org/projects/analytics/feeds/8z8k6vUfniLmWc2qGe6GMQsxBujvKRKuybLd8mdTbMFHwGfLH3oxK*MU0E8zM6go.atom
Comment 8 T. Gries 2013-10-17 20:56:33 UTC 
You appear to have a severe problem with your wiki installation. 

I added your feed to

http://openid-wiki.instance-proxy.wmflabs.org/wiki/Main_Page#RSS_Feeds and it _works_ there.

A small problem with not rendering the feed title item as link is known to me and will be repaired soon.
Comment 9 T. Gries 2013-10-17 21:39:01 UTC 
I am just fixing the "Undefined variable: txt in
/vagrant/mediawiki/extensions/RSS/RSSParser.php on line 376" problem !

Thanks for reporting.
Comment 10 Gerrit Notification Bot 2013-10-17 21:42:59 UTC 
Change 90441 had a related patch set (by Wikinaut) published:
Bug 55763

https://gerrit.wikimedia.org/r/90441
Comment 11 T. Gries 2013-10-17 21:44:19 UTC 
@Diederick

Please can you try https://gerrit.wikimedia.org/r/#/c/90441/ ?

I just added you as reviewer to that commit.

Use:

git fetch https://wikinaut@gerrit.wikimedia.org/r/mediawiki/extensions/RSS refs/changes/41/90441/2 && git checkout FETCH_HEAD
Comment 12 T. Gries 2013-10-17 21:45:35 UTC 
code is live on http://openid-wiki.instance-proxy.wmflabs.org/wiki/Main_Page
Comment 13 Gerrit Notification Bot 2013-10-17 21:47:13 UTC 
Change 90441 merged by Diederik:
Bug 55763

https://gerrit.wikimedia.org/r/90441
Comment 14 T. Gries 2013-10-17 21:50:40 UTC 
fix tested, committed, merged.
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links