Last modified: 2014-06-09 15:55:58 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T57784, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 55784 - VisualEditor: Move floating functionality from SurfaceToolbar to Toolbar?
VisualEditor: Move floating functionality from SurfaceToolbar to Toolbar?
Status: ASSIGNED
Product: VisualEditor
Classification: Unclassified
Technical Debt (Other open bugs)
unspecified
All All
: High enhancement
: ---
Assigned To: Editing team bugs – take if you're interested!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-10-16 11:01 UTC by Roan Kattouw
Modified: 2014-06-09 15:55 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Roan Kattouw 2013-10-16 11:01:55 UTC
The floating code is in ve.ui.SurfaceToolbar instead of OO.ui.Toolbar, but cursory inspection of the code indicates that it doesn't reach into the surface and doesn't receive any events from the surface, apart from a minor bit that ensures the cursor isn't obscured by the toolbar.

Wanting to float a toolbar seems generic enough, so couldn't this be made into generic OO.ui functionality?

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links