Last modified: 2013-10-16 20:58:23 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T57798, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 55798 - CirrusSearch blows up on really really long queries in production
CirrusSearch blows up on really really long queries in production
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
CirrusSearch (Other open bugs)
unspecified
All All
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2013-10-16 16:55 UTC by Nik Everett
Modified: 2013-10-16 20:58 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Nik Everett 2013-10-16 16:55:20 UTC 
CirrusSearch fails on really really long queries like this:
asdfffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffasdfffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffasdfffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffasdfffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff
Comment 1 Nik Everett 2013-10-16 16:58:15 UTC 
But this doesn't seem to happen in dev.
Comment 2 Nik Everett 2013-10-16 18:42:02 UTC 
This is caused by pcre backtracking - in prod we must have the limit lower than in dev.  Either way, I'll remove the offending regex and replace it with a loop over the characters.  It'll probably be faster any way.
Comment 3 Gerrit Notification Bot 2013-10-16 20:41:42 UTC 
Change 90200 had a related patch set uploaded by Manybubbles:
Improvements when searching long strings

https://gerrit.wikimedia.org/r/90200
Comment 4 Gerrit Notification Bot 2013-10-16 20:43:01 UTC 
Change 90202 had a related patch set uploaded by Manybubbles:
Tests for unbalanced quotes

https://gerrit.wikimedia.org/r/90202
Comment 5 Gerrit Notification Bot 2013-10-16 20:57:36 UTC 
Change 90200 merged by jenkins-bot:
Improvements when searching long strings

https://gerrit.wikimedia.org/r/90200
Comment 6 Gerrit Notification Bot 2013-10-16 20:57:52 UTC 
Change 90202 merged by jenkins-bot:
Tests for unbalanced quotes

https://gerrit.wikimedia.org/r/90202
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links