Last modified: 2013-10-18 23:26:02 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T57820, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 55820 - Investigate crashers in https://gerrit.wikimedia.org/r/#/c/90180/
Investigate crashers in https://gerrit.wikimedia.org/r/#/c/90180/
Status: RESOLVED FIXED
Product: Parsoid
Classification: Unclassified
General (Other open bugs)
unspecified
All All
: High normal
: ---
Assigned To: Arlo Breault
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-10-17 00:39 UTC by Gabriel Wicke
Modified: 2013-10-18 23:26 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Gabriel Wicke 2013-10-17 00:39:41 UTC
The crash in enwiki:Wikipedia:WikiProject_Yugoslavia/Sidebar looks odd. Attributes seem to be able to bypass the sanitizer there, which is not good. We should investigate how that is possible, and make sure it is prevented.
Comment 1 Gerrit Notification Bot 2013-10-17 03:57:37 UTC
Change 90287 had a related patch set uploaded by Arlolra:
Don't emit foster box in transclusion

https://gerrit.wikimedia.org/r/90287
Comment 2 Arlo Breault 2013-10-17 04:06:22 UTC
The reason for the first crasher is the following template,

{{навигационная полоса
|стиль_нечетных=
|содержание=

<table></table>

}}

What's happening is similar to the reason for dom.handleUnbalancedTables.js

The <td> containing the inner table as content is built up in a few tokens, forcing the tree builder to close the table right before the inner table, stealing its fosterbox. That foster box is a child of <div> and has no siblings, hence the original error. I think the thing to do (as in the patch) is just not emit the foster box for the inner table. We aren't really even using it.
Comment 3 Gerrit Notification Bot 2013-10-17 17:55:01 UTC
Change 90287 merged by jenkins-bot:
Don't emit foster box in transclusion

https://gerrit.wikimedia.org/r/90287
Comment 4 Gerrit Notification Bot 2013-10-17 21:09:02 UTC
Change 90436 had a related patch set uploaded by Arlolra:
Only copy data-parsoid attr to shadow meta from el

https://gerrit.wikimedia.org/r/90436
Comment 5 Gerrit Notification Bot 2013-10-17 23:44:43 UTC
Change 90436 merged by jenkins-bot:
Only copy data-parsoid attribute from element to shadow meta

https://gerrit.wikimedia.org/r/90436

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links