Last modified: 2013-11-20 15:52:18 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T57847, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 55847 - Interwiki tooltip: " in title is escaped


Summary:	Interwiki tooltip: " in title is escaped

Status:	RESOLVED FIXED

Product:	MediaWiki
Classification:	Unclassified
Component:	Interface (Other open bugs)
Version:	1.22.0
Hardware:	All All

Importance:	Low normal (vote)
Target Milestone:	1.22.0 release
Assigned To:	Umherirrender

URL:	https://de.wikipedia.org/wiki/Selbstf...
Whiteboard:
Keywords:	easy

Duplicates:	57309 (view as bug list)
Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2013-10-17 19:20 UTC by Raimond Spekking
Modified:	2013-11-20 15:52 UTC (History)
CC List:	5 users (show)

See Also:	55865
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Raimond Spekking 2013-10-17 19:20:17 UTC

If an interwiki tooltip contains a " in the target page name, the " is escaped:


Current interwiki tooltip for Polnish: 
12.8 cm Selbstfahrlafette auf VK3001(H) (Panzerselbstfahrlafette V)&quot;Sturer Emil&quot; – Polnisch

Expected output:
12.8 cm Selbstfahrlafette auf VK3001(H) (Panzerselbstfahrlafette V)"Sturer Emil" – Polnisch

see
[[pl:12.8 cm Selbstfahrlafette auf VK3001(H) (Panzerselbstfahrlafette V)"Sturer Emil"]]

Comment 1 Michael M. 2013-10-18 09:19:22 UTC

This also happens for & ([[Procter & Gamble]], e.g. Procter &amp; Gamble – German) and ' ([[America's Cup]], e.g. America&#039;s Cup – Old English)

Comment 2 Bartosz Dziewoński 2013-10-18 18:32:33 UTC

I guess the message shouldn't be ->escaped() in SkinTemplate::getLanguages.

Comment 3 Gerrit Notification Bot 2013-11-10 09:27:00 UTC

Change 94602 had a related patch set uploaded by Umherirrender:
Do not escape title attribute twice for tooltip-iwiki

https://gerrit.wikimedia.org/r/94602

Comment 4 Gerrit Notification Bot 2013-11-11 20:51:07 UTC

Change 94602 merged by jenkins-bot:
Do not escape title attribute twice for tooltip-iwiki

https://gerrit.wikimedia.org/r/94602

Comment 5 Umherirrender 2013-11-11 20:53:37 UTC

successfully merged

Comment 6 Umherirrender 2013-11-12 16:23:39 UTC

Please backport to 1.22rc1 to allow backport of bug 56129 . Thanks

Comment 7 Gerrit Notification Bot 2013-11-12 18:20:38 UTC

Change 94942 had a related patch set uploaded by Bartosz Dziewoński:
Do not escape title attribute twice for tooltip-iwiki

https://gerrit.wikimedia.org/r/94942

Comment 8 Bartosz Dziewoński 2013-11-12 18:22:48 UTC

Done. Note that 1.22 is not a stable version yet, so the flag currently refers to 1.21 and older versions; reopen and set milestone to 1.22.0 for backporting there.

(This would be way easier if the flag wasn't so stupidly named.)

Comment 9 Gerrit Notification Bot 2013-11-12 18:24:57 UTC

Change 94942 merged by Bartosz Dziewoński:
Do not escape title attribute twice for tooltip-iwiki

https://gerrit.wikimedia.org/r/94942

Comment 10 Bartosz Dziewoński 2013-11-20 15:52:18 UTC

*** Bug 57309 has been marked as a duplicate of this bug. ***

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links