Last modified: 2014-04-25 06:42:39 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T57860, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 55860 - Special:BannerRandom attempts to load insecure content for mobile domains on HTTPS
Special:BannerRandom attempts to load insecure content for mobile domains on ...
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
CentralNotice (Other open bugs)
master
All All
: High normal (vote)
: ---
Assigned To: Matt Walker
: mobile
: 56393 (view as bug list)
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2013-10-18 01:20 UTC by Arthur Richards
Modified: 2014-04-25 06:42 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Arthur Richards 2013-10-18 01:20:57 UTC 
To replicate, go to https://m.mediawiki.org - with console open, you should see an error like:

[blocked] The page at https://m.mediawiki.org/wiki/MediaWiki ran insecure content from http://meta.m.wikimedia.org/wiki/Special:BannerRandom?uselang=en&sitename=M…roject=wikimedia&anonymous=false&bucket=1&country=US&device=android&slot=6.

I presume this makes it impossible to run CN banners on mobile devices for logged in users.

I chatted briefly with Matt Walker about this and it sounds like this is the result of how infrastructure is currently architected, though there may be an easy solution of forcing mobile URLs in CentralNotice using MobileContext::getMobileUrl() from MobileFrontend.
Comment 1 Gerrit Notification Bot 2013-10-18 19:57:01 UTC 
Change 90639 had a related patch set uploaded by Mwalker:
Serve Mobile URLs to Mobile Users

https://gerrit.wikimedia.org/r/90639
Comment 2 Gerrit Notification Bot 2013-10-18 20:09:26 UTC 
Change 90639 merged by Adamw:
Serve Mobile URLs to Mobile Users

https://gerrit.wikimedia.org/r/90639
Comment 3 Arthur Richards 2013-10-30 18:22:43 UTC 
Looks like the patch was merged and I'm no longer seeing the issue on m.mediawiki.org. Can this bug be closed?
Comment 4 Matt Walker 2013-10-30 23:08:02 UTC 
eh... not really; the patch didn't work. So! New patch!
Comment 5 Matt Walker 2013-10-30 23:08:34 UTC 
*** Bug 56393 has been marked as a duplicate of this bug. ***
Comment 6 Gerrit Notification Bot 2013-10-30 23:08:48 UTC 
Change 92806 had a related patch set uploaded by Mwalker:
Serve Mobile URLs to Mobile Users

https://gerrit.wikimedia.org/r/92806
Comment 7 Gerrit Notification Bot 2013-10-30 23:39:04 UTC 
Change 92806 merged by jenkins-bot:
Serve Mobile URLs to Mobile Users

https://gerrit.wikimedia.org/r/92806
Comment 8 Andre Klapper 2014-02-14 13:04:03 UTC 
mwalker:
Patch was merged a while ago - is there more work left to do here (if yes: please reset the bug report status to NEW or ASSIGNED), or can you close this ticket as RESOLVED FIXED?
Comment 9 Andre Klapper 2014-04-25 06:42:39 UTC 
No reply to comment 8 - assuming this bug is FIXED.
If that is not the case: Please reopen and elaborate what is left to do here to get this report fixed.
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links