Last modified: 2013-12-05 05:00:23 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T57861, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 55861 - If a not valid JSON string is passed to action=flow in the params parameter, it throws an internal error


Summary:	If a not valid JSON string is passed to action=flow in the params parameter, ...

Status:	RESOLVED FIXED

Product:	MediaWiki extensions
Classification:	Unclassified
Component:	Flow (Other open bugs)
Version:	unspecified
Hardware:	All All

Importance:	Unprioritized normal (vote)
Target Milestone:	---
Assigned To:	Nobody - You can work on this!

URL:
Whiteboard:
Keywords:	easy

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2013-10-18 01:55 UTC by Kunal Mehta (Legoktm)
Modified:	2013-12-05 05:00 UTC (History)
CC List:	2 users (show)

See Also:
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Kunal Mehta (Legoktm) 2013-10-18 01:55:57 UTC

#0 /srv/mediawiki/includes/WebRequest.php(1493): FauxRequest->__construct(NULL, true)
#1 /srv/mediawiki/extensions/Flow/includes/api/ApiFlow.php(27): DerivativeRequest->__construct(Object(WebRequest), NULL, true)
#2 /srv/mediawiki/includes/api/ApiMain.php(834): ApiFlow->execute()
#3 /srv/mediawiki/includes/api/ApiMain.php(380): ApiMain->executeAction()
#4 /srv/mediawiki/includes/api/ApiMain.php(351): ApiMain->executeActionWithErrorHandling()
#5 /srv/mediawiki/api.php(73): ApiMain->execute()
#6 {main}

From ApiFlow.php:26-27
		$requestParams = json_decode( $params['params'], true );
		$request = new DerivativeRequest( $this->getContext()->getRequest(), $requestParams, true );

This is because json_decode returns NULL and DerivativeRequest doesn't want that.

Comment 1 spage 2013-10-21 08:38:44 UTC

The WMF core features team tracks this bug on Mingle card https://mingle.corp.wikimedia.org/projects/flow/cards/338, but people from the community are welcome to contribute here and in Gerrit.

Comment 2 Gerrit Notification Bot 2013-10-24 01:24:33 UTC

Change 91551 had a related patch set uploaded by Werdna:
(bug 55861) Better error message for invalid params parameter.

https://gerrit.wikimedia.org/r/91551

Comment 3 Gerrit Notification Bot 2013-10-25 15:23:25 UTC

Change 91551 merged by jenkins-bot:
(bug 55861) Better error message for invalid params parameter.

https://gerrit.wikimedia.org/r/91551

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links