Last modified: 2014-10-19 17:44:01 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T57873, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 55873 - Create Page#important_part_of_url
Create Page#important_part_of_url
Status: NEW
Product: Wikimedia
Classification: Unclassified
Quality Assurance (Other open bugs)
unspecified
All All
: Low enhancement (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-10-18 12:59 UTC by Željko Filipin
Modified: 2014-10-19 17:44 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Željko Filipin 2013-10-18 12:59:19 UTC
On several places in step code we have something like this[1]:

  @browser.url.should match /Special:UploadWizard/

We should create a method like Page#important_part_of_url (but we probably need a better name) that would return "Special:UploadWizard"[2].

1: https://github.com/wikimedia/qa-browsertests/blob/master/features/step_definitions/upload_wizard_steps.rb#L82
2: https://github.com/wikimedia/qa-browsertests/blob/master/features/support/pages/upload_wizard_page.rb#L6
Comment 1 Željko Filipin 2013-10-18 13:02:08 UTC
Then we could change the step code to something like:

@browser.url.should match on(UploadWizardPage).important_part_of_url

The implementation could be as simple as this:

class UploadWizardPage
...
    def self.important_part_of_url
    'Special:UploadWizard'
  end
  def self.url
    URL.url important_part_of_url
  end
...
end

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links