Last modified: 2014-11-19 00:34:44 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T57976, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 55976 - VisualEditor: Dialogs should disable "Apply changes" until a change is present
VisualEditor: Dialogs should disable "Apply changes" until a change is present
Status: ASSIGNED
Product: VisualEditor
Classification: Unclassified
Editing Tools (Other open bugs)
unspecified
All All
: Normal minor
: VE-deploy-nextup
Assigned To: Editing team bugs – take if you're interested!
:
: 58231 (view as bug list)
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2013-10-21 20:46 UTC by Chris McMahon
Modified: 2014-11-19 00:34 UTC (History)
10 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Chris McMahon 2013-10-21 20:46:45 UTC 
Seen in Reference and Transclusion, anywhere with an overlay containing a button saying 'Apply changes'. 

* Hover the cursor over an existing Reference or Transclusion. 
* Click the icon to invoke the Reference or Transclusion overlay
* Without making any changes, click 'Apply changes'

* Save page button goes from grey to active.

* Click Save page
* Click Review your changes. 

Get message "Could not start the review because your revision matches the latest version of this page."
Comment 1 Roan Kattouw 2014-10-24 02:49:44 UTC 
This is not an OOUI bug, moving back to VE. Rather, it's a bug in the individual dialogs in VE that apparently commit no-op transactions when you click Apply changes without changing anything. Also, in most dialogs we disable the Apply changes button when there is nothing to change.

Since this bug was filed in 2013, I imagine it might be mostly fixed now? We have some bugs in this area (filed individually as "Apply changes is enabled even though XYZ") but my impression is that generally we're pretty good about this now.
Comment 2 Alex Monk 2014-10-24 23:18:25 UTC 
No, I think this still applies to the places mentioned in the description (transclusions and references).
Comment 3 James Forrester 2014-11-19 00:34:44 UTC 
*** Bug 58231 has been marked as a duplicate of this bug. ***
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links