Last modified: 2013-10-22 04:37:59 UTC
Some tours are not configured to end upon clicking the final Okay button. This is because I forgot to add {action: 'end'}. However, we may want to automatically end tours in some circumstances, or even just on display of. See also bug 55983. This can be reproduced by taking the firstedit tour, clicking Okay on the last step ("You're almost done!"), then previewing any other page (doesn't matter if you save the current edit first). I'm not sure if this is technically a bug, since I don't remember an explicit requirement for it, but I think clicking Okay on the last step should probably end it. If we don't make a general solution to this (e.g. making the last step of a tour automatically default to action: 'end'), we should check all of the tours to see if this change should be made.
(In reply to comment #0) > Some tours are not configured to end upon clicking the final Okay button. > This > is because I forgot to add {action: 'end'}. However, we may want to > automatically end tours in some circumstances, or even just on display of. > See > also bug 55983. > > This can be reproduced by taking the firstedit tour, clicking Okay on the > last > step ("You're almost done!"), then previewing any other page (doesn't matter > if > you save the current edit first). I'm not sure if this is technically a bug, > since I don't remember an explicit requirement for it, but I think clicking > Okay on the last step should probably end it. > > If we don't make a general solution to this (e.g. making the last step of a > tour automatically default to action: 'end'), we should check all of the > tours > to see if this change should be made. I think making Okay on the last step automatically end a tour seems sane. Log data says that 314 users saw the final step of the firstedit tour 10 or more times. 14 of them saw it more than 50 times. Many of these users were no doubt previewing many times before saving, but there is no reason a user should be shown a step like "Don't forget to save!" that much.
