Last modified: 2013-11-08 19:19:18 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T58014, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 56014 - Match lightbox height / width ratios, font sizes, to mockup
Match lightbox height / width ratios, font sizes, to mockup
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
OAuth (Other open bugs)
master
All All
: High normal (vote)
: ---
Assigned To: Aaron Schulz
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-10-22 20:59 UTC by Chris Steipp
Modified: 2013-11-08 19:19 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Mockup from May (139.96 KB, image/png)
2013-10-22 20:59 UTC, Chris Steipp
Details
Screenshot with Aaron's patch (108.98 KB, image/png)
2013-10-24 20:59 UTC, Chris Steipp
Details

Description Chris Steipp 2013-10-22 20:59:53 UTC
Created attachment 13543 [details]
Mockup from May

UX would like the ratios of the lightbox for /authorize, and the font sizes, to more closely match the mockup (attached).

May, since there isn't a hight in pixles, can you give a good ratio for us to use?
Comment 1 Chris Steipp 2013-10-24 18:35:17 UTC
So the exact dimensions of May's mockup was 420x296 px, so that's about a 16:11 ratio. Let's do 420x296 exactly for now?

Font sizes in the mockup were 18 pt for the Name and "%App Name" sections, and 14 pt for the grants. The privacy policy was 12 pt.

We set the grants to 1em, and the heading to 1.3em, which is pretty much the exact proportions requested. So the only adjustment is the privacy policy and button text to be .85em instead of 1.
Comment 2 Gerrit Notification Bot 2013-10-24 20:31:18 UTC
Change 91671 had a related patch set uploaded by Aaron Schulz:
Font size, width, and padding tweaks to authorize form

https://gerrit.wikimedia.org/r/91671
Comment 3 Chris Steipp 2013-10-24 20:59:56 UTC
Created attachment 13567 [details]
Screenshot with Aaron's patch

After Aaron's patch, the looks pretty much match.
Comment 4 Gerrit Notification Bot 2013-10-24 21:34:10 UTC
Change 91671 merged by jenkins-bot:
Font size, width, and padding tweaks to authorize form

https://gerrit.wikimedia.org/r/91671
Comment 5 Chris Steipp 2013-11-06 04:46:06 UTC
May requested that we:

* Cut the space between "Hello World would like to.." and "Interact with pages.." into half.
* Indent the "Hi MGalloway…" to align with "Interact with pages..," not with the bullet point
* box color: #FFF with #CCC 1px outline
* allow button color: #00AF8B
* Text colors: #333
* Privacy policy text 12pt
Comment 6 Gerrit Notification Bot 2013-11-06 04:48:37 UTC
Change 93918 had a related patch set uploaded by CSteipp:
More UX changes

https://gerrit.wikimedia.org/r/93918
Comment 7 Gerrit Notification Bot 2013-11-06 20:14:35 UTC
Change 93918 merged by jenkins-bot:
More UX changes

https://gerrit.wikimedia.org/r/93918

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links