Last modified: 2013-10-31 23:22:44 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T58019, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 56019 - Allow QUnit to run with optional parameters


Summary:	Allow QUnit to run with optional parameters

Status:	RESOLVED FIXED

Product:	Wikimedia
Classification:	Unclassified
Component:	Continuous integration (Other open bugs)
Version:	wmf-deployment
Hardware:	All All

Importance:	Unprioritized normal (vote)
Target Milestone:	---
Assigned To:	Jan Zerebecki

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:	54849
	Show dependency tree / graph

Reported:	2013-10-22 22:28 UTC by Jon
Modified:	2013-10-31 23:22 UTC (History)
CC List:	3 users (show)

See Also:
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Jon 2013-10-22 22:28:05 UTC

Mobile JavaScript is currently sandboxed from desktop to keep the startup module size down and to prevent leakage of elements not yet ready for desktop mode.

To force this mode the QUnit tests need to be run in the mobile skin using:
http://localhost/w/index.php/Special:JavaScriptTest/qunit?useformat=mobile

It would be good if the Jenkins script could be setup to add this useformat=mobile parameter so the correct tests run...

Comment 1 Antoine "hashar" Musso (WMF) 2013-10-23 07:54:39 UTC

We could potentially hack the qunit macro to append '?useformat=mobile whenever the ZUUL_PROJECT is set to mediawiki/extension/MobileFrontend.

Would you like to have both jobs running?  Aka the default + useformat=mobile one?

Comment 2 Jon 2013-10-23 15:33:14 UTC

Only a single job is required right now, although in future we are likely to need 2 so it depends what is easiest to do now... :)

Comment 3 Gerrit Notification Bot 2013-10-30 23:01:31 UTC

Change 92804 had a related patch set uploaded by JanZerebecki:
Add mwext-MobileFrontend-qunit-mobile with useformat=mobile.

https://gerrit.wikimedia.org/r/92804

Comment 4 Antoine "hashar" Musso (WMF) 2013-10-31 22:38:27 UTC

Zuul triggers deployed by https://gerrit.wikimedia.org/r/#/c/92997/, the job is made non voting to prevent blocking folks while their tests are being polished up.

Assigned to Jan since he did most of the work (congratulations Jan).

Comment 5 Gerrit Notification Bot 2013-10-31 22:38:38 UTC

Change 92804 merged by jenkins-bot:
Add mwext-MobileFrontend-qunit-mobile with useformat=mobile.

https://gerrit.wikimedia.org/r/92804

Comment 6 Jon 2013-10-31 23:14:43 UTC

Thanks Jan. Sadly it's not quite working for unknown reasons - for some reason the URL generated is relative rather than absolute..

Comment 7 Jon 2013-10-31 23:22:44 UTC

Wait I take it back.. now it seems to be working correctly.
It's desktop tests that are not working..

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links