Last modified: 2013-10-30 15:08:01 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T58020, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 56020 - [INVALID] number of words below search snippets
[INVALID] number of words below search snippets
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
CirrusSearch (Other open bugs)
master
All All
: High minor (vote)
: ---
Assigned To: Nobody - You can work on this!
https://it.wiktionary.org/w/index.php...
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-10-22 22:56 UTC by Nemo
Modified: 2013-10-30 15:08 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Nemo 2013-10-22 22:56:50 UTC
In example URL:

maggiore
Italiano Aggettivo maggiore m sing (pl: maggiori) (musica) relativo al
byte ([INVALID] parole) - 16:15, 5 set 2013

airone bianco maggiore
Un airone bianco maggiore (Casmerodius albus) Italiano Locuzione
byte ([INVALID] parole) - 20:27, 8 lug 2013

malfattore
Italiano Sostantivo malfattore m sing (pl: malfattori) chi commette reati Sillabazione mal | fat |
650 byte (650 parole) - 19:26, 24 ago 2013
Comment 1 Kevin Israel (PleaseStand) 2013-10-23 00:11:55 UTC
Probably introduced by 2f801f15c07f.

I'm not familiar with the CirrusSearch code, though it would seem that for some CirrusSearchResults, both $result->text_words and $result->text_bytes are some non-integer, non-null value.
Comment 2 Kevin Israel (PleaseStand) 2013-10-23 03:01:35 UTC
(In reply to comment #1)
> I'm not familiar with the CirrusSearch code, though it would seem that for
> some
> CirrusSearchResults, both $result->text_words and $result->text_bytes are
> some
> non-integer, non-null value.

Actually, null (or an array or object containing null) would be the only thing CirrusSearchResult::getWordCount() could be returning, because nothing else would cause "[INVALID]" to be shown...

Could $result->textLen be null for some reason?
Comment 3 Nik Everett 2013-10-25 01:14:46 UTC
I'm with Kevin, it had to be some mistake I made with 2f801f15c07f.  I'm not sure we'll ever know because we had a mini disaster and ended up rebuilding the search indexes before I could reproduce the problem.  Now that the indexes are rebuilt, everything is working.  The thing is, that wasn't supposed to be required.  It was supposed to default to that textLen field we'd been writing to Elasticsearch since we started the project.

Its working so I'm resolving the bug, but I'm not happy with this because I don't know _what_ I didn't wrong and don't think I'm going to be able to figure it out.
Comment 4 Nik Everett 2013-10-28 14:43:20 UTC
I've been able to reproduce this locally so I should be able to figure out what caused this.
Comment 5 Gerrit Notification Bot 2013-10-28 19:09:39 UTC
Change 92357 had a related patch set uploaded by Manybubbles:
Prevent search index updates of nonexistant pages

https://gerrit.wikimedia.org/r/92357
Comment 6 Gerrit Notification Bot 2013-10-28 19:12:58 UTC
Change 92359 had a related patch set uploaded by Manybubbles:
Tests catching some invalid word count causes

https://gerrit.wikimedia.org/r/92359
Comment 7 Gerrit Notification Bot 2013-10-28 22:15:47 UTC
Change 92357 merged by jenkins-bot:
Prevent search index updates of nonexistant pages

https://gerrit.wikimedia.org/r/92357
Comment 8 Gerrit Notification Bot 2013-10-28 22:17:13 UTC
Change 92359 merged by jenkins-bot:
Tests catching some invalid word count causes

https://gerrit.wikimedia.org/r/92359

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links