Last modified: 2013-10-30 15:13:48 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T58031, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 56031 - Move linkprefix out of $messages and use a simpler input convention
Move linkprefix out of $messages and use a simpler input convention
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Internationalization (Other open bugs)
1.22.0
All All
: Unprioritized normal (vote)
: ---
Assigned To: Brad Jorsch
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-10-23 01:42 UTC by Tim Starling
Modified: 2013-10-30 15:13 UTC (History)
9 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Tim Starling 2013-10-23 01:42:20 UTC
Years ago, in Messages*.php, linktrail was moved out of $messages and into a separate variable ($linkTrail) with a dedicated accessor in Language. This was because changing the link trail is potentially very disruptive, and the need for sysops to legitimately edit the link trail is very rare.

The same treatment should be given to linkprefix. However, after Iaa7eaa44 (and arguably before it), the regex is too complex to expect translators to be able to accurately maintain. I suggest taking advantage of the migration of linkprefix out of $messages to simultaneously change its definition, from a whole regex to a character class, similar to $wgLegalTitleChars. The actual implementation of the reverse search for characters not matching the character class would be in Parser.php rather than duplicated in 38 language files.

The /u modifier could be used unconditionally.

The few regexes that can't currently be expressed in this way (uk, cu, udm) are apparently not like that for any fundamental language-related reason -- they could just as easily include entire runs of quotation marks in the link text, like crh, cv and uz.
Comment 1 Gerrit Notification Bot 2013-10-23 18:35:01 UTC
Change 91425 had a related patch set uploaded by Anomie:
Remove linkprefix message, add $linkPrefixCharset

https://gerrit.wikimedia.org/r/91425
Comment 2 Gerrit Notification Bot 2013-10-30 15:12:41 UTC
Change 91425 merged by jenkins-bot:
Remove linkprefix message, add $linkPrefixCharset

https://gerrit.wikimedia.org/r/91425

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links