Last modified: 2014-11-17 21:40:52 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T58046, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 56046 - Have the option of cloning things from github
Have the option of cloning things from github
Status: PATCH_TO_REVIEW
Product: MediaWiki-Vagrant
Classification: Unclassified
General (Other open bugs)
unspecified
All All
: Unprioritized normal
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-10-23 15:11 UTC by Yuvi Panda
Modified: 2014-11-17 21:40 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Yuvi Panda 2013-10-23 15:11:17 UTC
Since Gerrit is all the time rather very slow for me and also has intermittent failures - clones just hang forever, making provision hang forever.
Comment 1 Yuvi Panda 2013-10-23 15:24:54 UTC
Hacky patch that clones from github directly.

diff --git a/puppet/modules/git/manifests/clone.pp b/puppet/modules/git/manifests/clone.pp
index 5d6ab62..d1edaa9 100644
--- a/puppet/modules/git/manifests/clone.pp
+++ b/puppet/modules/git/manifests/clone.pp
@@ -24,7 +24,7 @@ define git::clone($directory, $remote=undef) {
     include git
 
     $url = $remote ? {
-        undef   => sprintf($git::urlformat, $title),
+        undef   => sprintf($git::urlformat, regsubst($title, '/', '-', 'G')),
         default => $remote,
     }
 
diff --git a/puppet/modules/git/manifests/init.pp b/puppet/modules/git/manifests/init.pp
index c36ea4b..f5949c8 100644
--- a/puppet/modules/git/manifests/init.pp
+++ b/puppet/modules/git/manifests/init.pp
@@ -19,7 +19,7 @@
 #  }
 #
 class git(
-    $urlformat = 'https://gerrit.wikimedia.org/r/p/%s.git',
+    $urlformat = 'https://github.com/wikimedia/%s.git',
 ) {
     package { 'git':
         ensure  => latest,
Comment 2 Gerrit Notification Bot 2014-09-01 16:48:34 UTC
Change 157695 had a related patch set uploaded by BryanDavis:
Support Github URLs

https://gerrit.wikimedia.org/r/157695
Comment 3 Bryan Davis 2014-11-17 21:36:26 UTC
Bulk unassigning bugs from Ori.
Comment 4 Bryan Davis 2014-11-17 21:40:52 UTC
Yuvi, are you still interested in this feature? If so review of the patch and help advocating for the feature would be appreciated. If not I'll probably just abandon the patch I made.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links