Last modified: 2013-11-12 16:22:44 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T58051, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 56051 - Catchable fatal error: Argument 1 passed to Wikibase\Claims::getClaimsForProperty() in property parser function


Summary:	Catchable fatal error: Argument 1 passed to Wikibase\Claims::getClaimsForProp...

Status:	VERIFIED FIXED

Product:	MediaWiki extensions
Classification:	Unclassified
Component:	WikidataClient (Other open bugs)
Version:	master
Hardware:	All All

Importance:	Unprioritized critical (vote)
Target Milestone:	---
Assigned To:	Wikidata bugs

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2013-10-23 16:08 UTC by Aude
Modified:	2013-11-12 16:22 UTC (History)
CC List:	2 users (show)

See Also:
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Aude 2013-10-23 16:08:41 UTC

I am getting a fatal error in the client:

Catchable fatal error: Argument 1 passed to Wikibase\Claims::getClaimsForProperty() must be an instance of Wikibase\DataModel\Entity\PropertyId, instance of Wikibase\DataModel\Entity\EntityId given, called in /var/www/common/php-master/extensions/Wikibase/client/includes/parserhooks/PropertyParserFunctionRenderer.php on line 86 and defined in /var/www/common/php-master/extensions/WikibaseDataModel/DataModel/Claim/Claims.php on line 370

This issue is caused by older data from memcached that my install is using. The TermPropertyLabelResolver pulls the ids from memcached.

e.g. 

'coordinate' => Wikibase\DataModel\Entity\EntityId::__set_state(array( 'entityType' => 'property', 'serialization' => 'P5', ))

These are EntityId objects, but not specifically PropertyId objects that Claims::getClaimsForProperty() now requires.

This issue *will* hit us in production, so must fix asap.

Comment 1 Aude 2013-10-23 16:09:19 UTC

and we need to check every possible place this issue might occur

Comment 2 Gerrit Notification Bot 2013-10-23 16:35:50 UTC

Change 91406 had a related patch set uploaded by Aude:
(bug 56051) Use PropertyId objects in TermPropertyLabelResolver, ensure recache when needed

https://gerrit.wikimedia.org/r/91406

Comment 3 Gerrit Notification Bot 2013-10-23 18:10:01 UTC

Change 91406 merged by jenkins-bot:
(bug 56051) Use PropertyId objects in TermPropertyLabelResolver, ensure recache when needed

https://gerrit.wikimedia.org/r/91406

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links