Last modified: 2014-03-27 04:35:25 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T58125, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 56125 - GuidedTour does not log JavaScript exceptions and errors properly in all browsers
GuidedTour does not log JavaScript exceptions and errors properly in all brow...
Status: NEW
Product: MediaWiki extensions
Classification: Unclassified
GuidedTour (Other open bugs)
master
All All
: Low minor (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-10-24 21:57 UTC by Matthew Flaschen
Modified: 2014-03-27 04:35 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
This is a screenshot of Firebug. It shows a secondary error that results from the original failure to load the tour. The original syntax error is not shown. (12.04 KB, image/png)
2013-10-24 21:57 UTC, Matthew Flaschen
Details
Firebug with extension-defined tour (18.42 KB, image/png)
2013-10-24 22:19 UTC, Matthew Flaschen
Details
Firefox Web Console with extension-defined tour (7.48 KB, image/png)
2013-10-25 08:19 UTC, Matthew Flaschen
Details
Chromium with extension-defined tour (8.13 KB, image/png)
2013-10-25 08:22 UTC, Matthew Flaschen
Details
Firebug with on-wiki tour (18.11 KB, image/png)
2013-10-25 08:29 UTC, Matthew Flaschen
Details
Firefox Web Console with on-wiki tour (9.21 KB, image/png)
2013-10-25 08:34 UTC, Matthew Flaschen
Details
Chromium with on-wiki tour (9.19 KB, image/png)
2013-10-25 08:37 UTC, Matthew Flaschen
Details

Description Matthew Flaschen 2013-10-24 21:57:37 UTC
Created attachment 13568 [details]
This is a screenshot of Firebug.  It shows a secondary error that results from the original failure to load the tour.  The original syntax error is not shown.

This applies to both extension-defined and on-wiki tours, although they use slightly different logging formats and load orders (which affects where exceptions may be caught).

I'm attaching screenshots of each main scenario, for a fresh load (no cookie).
Comment 1 Matthew Flaschen 2013-10-24 21:59:00 UTC
I forgot to say, the first attachment is for an extension-defined tour.
Comment 2 Matthew Flaschen 2013-10-24 22:19:07 UTC
Created attachment 13571 [details]
Firebug with extension-defined tour

Correction, the first one is incorrect.  I think it wasn't in debug mode, which all of these are meant to be.

So this is the correct Firebug, in debug mode, showing the underlying SyntaxError and the TypeError.  The main issue is that the SyntaxError isn't attributed to the right file.
Comment 3 Matthew Flaschen 2013-10-25 08:19:28 UTC
Created attachment 13580 [details]
Firefox Web Console with extension-defined tour

Firefox Web Console, in debug mode. It correctly shows the SyntaxError, but the TypeError is not handled right.  Even on click, it doesn't show useful information, except that there's a TypeError.
Comment 4 Matthew Flaschen 2013-10-25 08:22:26 UTC
Created attachment 13581 [details]
Chromium with extension-defined tour

It shows the underlying SyntaxError properly.  The TypeError is displayed as text, not clickable.
Comment 5 Matthew Flaschen 2013-10-25 08:29:01 UTC
Created attachment 13582 [details]
Firebug with on-wiki tour

Correctly displays SyntaxError, albeit with no line information.
Comment 6 Matthew Flaschen 2013-10-25 08:34:43 UTC
Created attachment 13583 [details]
Firefox Web Console with on-wiki tour

Firefox Web Console with on-wiki tour, in debug mode.  Similar to the extension example, [object Error] is clickable, but it doesn't show anything useful.
Comment 7 Matthew Flaschen 2013-10-25 08:37:41 UTC
Created attachment 13584 [details]
Chromium with on-wiki tour

Chromium with on-wiki tour, in debug mode.  Very close to the extension-defined version.  The SyntaxError is not clickable.
Comment 8 Matthew Flaschen 2014-03-27 04:35:25 UTC
See also https://code.google.com/p/chromium/issues/detail?id=228909 .  Chromium has been fixed since I last looked at this (I commented on that), so some of this may be improved by extending Error.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links