Last modified: 2013-11-12 18:57:39 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T58129, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 56129 - Rename tooltip-iwiki to something more consistent with mediawiki terminology
Rename tooltip-iwiki to something more consistent with mediawiki terminology
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Internationalization (Other open bugs)
1.22.0
All All
: High normal (vote)
: 1.22.0 release
Assigned To: Siebrand Mazeland
: i18n
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-10-24 22:26 UTC by Krinkle
Modified: 2013-11-12 18:57 UTC (History)
9 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Krinkle 2013-10-24 22:26:52 UTC
0d7a30fa27ebaefb5d89693bbe658916b982c082 introduced message key "tooltip-iwiki".

The term or abbreviation "iwiki" doesn't exist and has no meaning in MediaWiki. To avoid more ambiguity (as if we don't have enough confusing and ambiguous *wiki terms) please rename this to something else before the 1.22.0 release.


Filing a bug instead of a commit because this probably needs a little bit of coordination with translatewiki to assure translation history and attribution is preserved. And that part is harder than the commit, so the commit would naturally follow at that point.
Comment 1 Bartosz Dziewoński 2013-10-24 22:28:57 UTC
Related: bug 55865, 55847.
Comment 2 James Forrester 2013-10-24 22:40:22 UTC
This should probably block MW1.22 to avoid people depending on it and turning it into a major headache to fix.
Comment 3 Gerrit Notification Bot 2013-11-12 13:18:40 UTC
Change 94893 had a related patch set uploaded by Siebrand:
Change interlanguage link title message key

https://gerrit.wikimedia.org/r/94893
Comment 4 Gerrit Notification Bot 2013-11-12 13:30:18 UTC
Change 94893 merged by jenkins-bot:
Change interlanguage link title message key

https://gerrit.wikimedia.org/r/94893
Comment 5 Siebrand Mazeland 2013-11-12 13:38:15 UTC
I think I can close this now, and mark this for backporting. Please let me know if I did something wrong...
Comment 6 Bartosz Dziewoński 2013-11-12 14:28:26 UTC
1.22 is not a stable release yet, so you should just backport the changes to the REL1_22 branch (you can do it using gerrit's "Cherry Pick To" button) and self-merge. I'd do it, but I don't know how such changes are handled by TWN.
Comment 7 Siebrand Mazeland 2013-11-12 14:33:27 UTC
(In reply to comment #6)
> 1.22 is not a stable release yet, so you should just backport the changes to
> the REL1_22 branch (you can do it using gerrit's "Cherry Pick To" button) and
> self-merge. I'd do it, but I don't know how such changes are handled by TWN.

For 1.22 it's not time critical, so you could have just gone ahead. I'll see if I can cherry pick.
Comment 8 Siebrand Mazeland 2013-11-12 14:35:03 UTC
(In reply to comment #7)
> For 1.22 it's not time critical, so you could have just gone ahead. I'll see
> if I can cherry pick.

Gerrit tells me: Could not create a merge commit during the cherry pick.
Comment 9 Umherirrender 2013-11-12 16:22:53 UTC
(In reply to comment #8)
> (In reply to comment #7)
> For 1.22 it's not time critical, so you could
> have just gone ahead. I'll see
> if I can cherry pick.

Gerrit tells me:
> Could not create a merge commit during the cherry pick.

Sounds like Gerrit change #94602 has to cherry pick first to avoid the merge conflict.
Comment 10 Gerrit Notification Bot 2013-11-12 18:26:22 UTC
Change 94945 had a related patch set uploaded by Bartosz Dziewoński:
Change interlanguage link title message key

https://gerrit.wikimedia.org/r/94945
Comment 11 Bartosz Dziewoński 2013-11-12 18:27:18 UTC
I cherry-picked and merged that, and submitted a cherry-pick for this too (see above). I'll let Siebrand/Raimond merge and sort it out at TWN.
Comment 12 Gerrit Notification Bot 2013-11-12 18:46:53 UTC
Change 94945 merged by MarkAHershberger:
Change interlanguage link title message key

https://gerrit.wikimedia.org/r/94945
Comment 13 Bartosz Dziewoński 2013-11-12 18:57:39 UTC
Well, I assume Mark knows what he's doing.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links