Last modified: 2014-08-17 11:30:23 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T58138, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 56138 - Cascade order of fallback CSS properties is wrong
Cascade order of fallback CSS properties is wrong
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
UniversalLanguageSelector (Other open bugs)
unspecified
All All
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-10-24 23:56 UTC by Daniel Friesen
Modified: 2014-08-17 11:30 UTC (History)
8 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Daniel Friesen 2013-10-24 23:56:55 UTC
Taking a look at the ULS css the css is inconsistent and incorrectly ordered:
https://git.wikimedia.org/blob/mediawiki%2Fextensions%2FUniversalLanguageSelector/cf52230d3581b69c7ecacfb256e8f95e8f742ae9/resources%2Fcss%2Fext.uls.css

filter and -ms-filter should be at the very start before any of the gradient rules.

-webkit-gradient and -webkit-linear-gradient should be before linear-gradient.

Also -ms-linear-gradient doesn't exist. At least not outside of the preview version of IE10 no-one should be using since IE10 has a real release.
Comment 1 Daniel Friesen 2013-10-25 00:03:52 UTC
Also has the use of filter for gradients been properly tested in every version of IE? There are reports of filter and border-radius conflicting in IE9.
Comment 2 Pau Giner 2013-10-29 15:38:33 UTC
The standard (non-prefixed version) should appear at the end. This should be corrected where that is not happening. The issue seems to be present at lines 156, 214, and 268.

I'm not sure -ms-filter position has any practical implications since it is a different property (so overriding should not apply), but I have no idea if there are practical consequences. I would even consider dropping the MS specific -ms-filter prefix since they only add non-essential visual decoration for old browser versions.

Regarding "-ms-linear-gradient", IE seems to support the standard version (where it supports any kind of gradients) according to http://caniuse.com/css-gradients  so it makes sense to remove the "-ms-linear-gradient".
Comment 3 Siebrand Mazeland 2013-10-29 16:31:41 UTC
Submitted a patch upstream for a single usage of "-ms-linear-gradient" in jQuery.ULS: https://github.com/wikimedia/jquery.uls/pull/114
Comment 4 Gerrit Notification Bot 2013-10-29 16:43:25 UTC
Change 92548 had a related patch set uploaded by Siebrand:
Update order of CSS properties

https://gerrit.wikimedia.org/r/92548
Comment 5 Gerrit Notification Bot 2013-10-30 12:22:56 UTC
Change 92548 merged by jenkins-bot:
Update order of CSS properties

https://gerrit.wikimedia.org/r/92548
Comment 6 Andre Klapper 2014-02-14 12:46:34 UTC
Patch was merged a while ago - is there more work left to do here (if yes: please reset the bug report status to NEW or ASSIGNED), or can you close this ticket as RESOLVED FIXED?
Comment 7 Andre Klapper 2014-05-20 10:37:51 UTC
Patch was merged a while ago - is there more work left to do here (if yes: please reset the bug report status to NEW or ASSIGNED), or can you close this ticket as RESOLVED FIXED?
Comment 8 Andre Klapper 2014-08-17 11:30:23 UTC
No reply to comment 6 and comment 7 - assuming this bug is FIXED.
If that is not the case: Please reopen and elaborate what is left to do here to get this report fixed.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links