Last modified: 2014-02-02 19:39:20 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T58184, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 56184 - Allow 3-way merge from arbitary revisions
Allow 3-way merge from arbitary revisions
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Page editing (Other open bugs)
1.22.0
All All
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-10-25 19:09 UTC by Liangent
Modified: 2014-02-02 19:39 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Liangent 2013-10-25 19:09:35 UTC
This allows the following cool "editprotected" flow:

1. Requester puts the modified version of the requested page somewhere else (maybe a subpage of talk page).
2. Requester tells admins revision ids of the modified version and the original revision which the modified one is based on, possibly with a gadget.
3. An admin edits the page with &undoafter=<modified revid>&undo=<original revid>.
4. If there's a conflict, admins can check &diff=<modified revid>&oldid=<original revid> and manually apply that, or ask the requester to submit a new "patch".

Actually existing code can work in this way, and it's only some sanity check which blocks that. Gerrit change #91943 is a demonstration of removal of that.
Comment 1 Gerrit Notification Bot 2013-10-25 19:10:07 UTC
Change 91943 had a related patch set uploaded by Liangent:
DO NOT MERGE

https://gerrit.wikimedia.org/r/91943
Comment 2 Liangent 2013-10-25 19:13:25 UTC
Besides the check, "# If they got undoafter and undo round the wrong way, switch them" also needs to be removed. I'm not sure whether this is feasible, but &diff=&oldid= is not working in this way (to be smart and swap values when "needed", and IIRC it was working in this way).
Comment 3 Gerrit Notification Bot 2014-01-29 23:56:06 UTC
Change 91943 merged by jenkins-bot:
(bug 56184) Allow 3-way merge from arbitrary revisions

https://gerrit.wikimedia.org/r/91943

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links