Last modified: 2013-11-07 22:11:23 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T58201, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 56201 - Apply mw.log.deprecate to deprecated functions from wikibits.js
Apply mw.log.deprecate to deprecated functions from wikibits.js
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
JavaScript (Other open bugs)
1.20.x
All All
: Normal enhancement (vote)
: 1.22.x release
Assigned To: Krinkle
: easy
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2013-10-26 12:01 UTC by Helder
Modified: 2013-11-07 22:11 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Helder 2013-10-26 12:01:44 UTC 
There are various functions listed as deprecated at
https://www.mediawiki.org/wiki/ResourceLoader/JavaScript_Deprecations#wikibits.js
which are not yet marked with mw.log.deprecate in the code[1]. 

E.g. window.injectSpinner and window.removeSpinner, which were just mentioned at [2].


[1] https://git.wikimedia.org/blob/mediawiki%2Fcore.git/c14f41892426aa8a560ea2a78350cf1f75c13bc9/skins%2Fcommon%2Fwikibits.js

[2] https://www.mediawiki.org/wiki/Thread:Talk:Requests_for_comment/Isolate_custom_jQuery_libraries/already_loading_Spinner,_other_spinner_notes
Comment 1 Helder 2013-10-31 09:07:22 UTC 
Fixed by Krinkle on
https://gerrit.wikimedia.org/r/92788
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links