Last modified: 2014-06-23 16:06:56 UTC
Created attachment 13600 [details] Patch to part of the doxygen comment for DatabaseBase::select() The doxygen comment in Database.php states: "The value is an array with two elements, numbered 0 and 1. The first gives the type of join, the second is an SQL fragment giving the join condition for that table." Actually the function accepts more than one condition, which is a useful feature and should be documented. See attached patch.
Thanks for the patch. Can you upload it to gerrit, our code review system? See [[mw:Developer access]] for help on how to use it, or try the patch uploader at http://tools.wmflabs.org/gerrit-patch-uploader .
Change 92301 had a related patch set uploaded by Bartosz Dziewoński: Update documentation for $join_conds in DatabaseBase::select() https://gerrit.wikimedia.org/r/92301
I'm afraid that was mistake, I had overlooked a level of parentheses. The value is indeed an array with two elements, where the second can be an array. So the documentation is correct in the present state.
Change 92301 abandoned by Bartosz Dziewoński: Update documentation for $join_conds in DatabaseBase::select() Reason: Per bug. Whoops. https://gerrit.wikimedia.org/r/92301
