Last modified: 2014-11-05 14:45:30 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T58246, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 56246 - Getting rid of direct API calls from within jQuery.wikibase.***view widgets
Getting rid of direct API calls from within jQuery.wikibase.***view widgets
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
WikidataRepo (Other open bugs)
unspecified
All All
: Low minor with 1 vote (vote)
: ---
Assigned To: Wikidata bugs
u=dev c=frontend p=0
: javascript
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2013-10-28 14:44 UTC by Daniel A. R. Werner
Modified: 2014-11-05 14:45 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Daniel A. R. Werner 2013-10-28 14:44:22 UTC 
Currently jQuery.wikibase's .claimview, .statementview, .claimlistview and .referenceview are handling API calls directly to save the data model object they are representing.

Each of those widgets is constructing a new wb.AbstractedRepoApi() instance and calling the API action for handling its data model object.

Depending on the actual implementation, this had the potential to significantly increasing the widgets testability, reusability and simplicity by redefining the widget's responsibility to solely act as a view serving the interface for editing a model (or "view model" following the example of jQuery.wikibase.snakview).
The way how to actually do this had to be carefully considered and discussed.
Comment 1 Gerrit Notification Bot 2014-10-16 12:05:26 UTC 
Change 166018 had a related patch set uploaded by Adrian Lang:
Introduce SiteLinksChanger

https://gerrit.wikimedia.org/r/166018
Comment 2 Gerrit Notification Bot 2014-10-23 16:27:15 UTC 
Change 166018 merged by Thiemo Mättig (WMDE):
Introduce SiteLinksChanger

https://gerrit.wikimedia.org/r/166018
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links