Last modified: 2014-01-09 18:28:08 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T58255, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 56255 - Use $linkPrefixCharset instead of the linkprefix regexp in WikiConfig
Use $linkPrefixCharset instead of the linkprefix regexp in WikiConfig
Status: RESOLVED FIXED
Product: Parsoid
Classification: Unclassified
General (Other open bugs)
unspecified
All All
: High normal
: ---
Assigned To: Gabriel Wicke
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2013-10-28 16:52 UTC by Gabriel Wicke
Modified: 2014-01-09 18:28 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Gabriel Wicke 2013-10-28 16:52:00 UTC 
https://gerrit.wikimedia.org/r/#/c/91425/ will add a linkprefixcharset entry in the site info instead of the occasionally-broken linkprefix regexp. We should use that whenever it is available, but fall back to the old-style linkprefix regexp for backwards-compat.

This might also implicitly fix bug 52855.
Comment 1 Gabriel Wicke 2013-10-28 16:56:48 UTC 
https://gerrit.wikimedia.org/r/#/q/Iaa7eaa44,n,z already changed the regexp syntax already, which breaks parsing of wikis with link prefix in production and rt testing. Test case:

node roundtrip-test.js --prefix ar 'مرس،_إب'

So we'll have to add handling for the new regexp syntax in the interim to avoid polluting the cache with broken link prefix handling.
Comment 2 Gerrit Notification Bot 2014-01-07 20:52:44 UTC 
Change 106106 had a related patch set uploaded by GWicke:
Fix link prefix and trail regexp handling

https://gerrit.wikimedia.org/r/106106
Comment 3 Gerrit Notification Bot 2014-01-08 02:12:23 UTC 
Change 106106 merged by jenkins-bot:
Fix link prefix and trail regexp handling

https://gerrit.wikimedia.org/r/106106
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links