Last modified: 2014-02-09 23:14:15 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T58268, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 56268 - Flow: Flow's text fields are not size restricted
Flow: Flow's text fields are not size restricted
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
Flow (Other open bugs)
unspecified
All All
: High normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-10-28 18:42 UTC by Oliver Keyes
Modified: 2014-02-09 23:14 UTC (History)
6 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Screenshot2 (1.60 MB, image/png)
2013-10-28 18:42 UTC, Oliver Keyes
Details
Screenshot1 (1.26 MB, image/png)
2013-10-28 18:43 UTC, Oliver Keyes
Details

Description Oliver Keyes 2013-10-28 18:42:53 UTC
Created attachment 13603 [details]
Screenshot2

In both comments and the header text, images are not restricted to conform to the sizing requirements of the page - see screenshots. Obviously this is potentially veeeeery disruptive.
Comment 1 Oliver Keyes 2013-10-28 18:43:15 UTC
Created attachment 13604 [details]
Screenshot1
Comment 2 spage 2013-10-29 07:44:27 UTC
The WMF core features team tracks this bug on Mingle card https://mingle.corp.wikimedia.org/projects/flow/cards/370, but people from the community are welcome to contribute here and in Gerrit.
Comment 3 Maryana Pinchuk 2013-10-29 18:11:57 UTC
I changed this bug to be a bit more general, since it's not just images that spill out of Flow text fields (e.g., http://ee-flow.wmflabs.org/w/index.php?title=User_talk:Maryana&workflow=0506af29cfae6e5b09a3fa163e68c4ac&action=view#flow-post-0506af29cfba6e5b09a3fa163e68c4ac).
Comment 4 Andrew Garrett 2013-11-05 07:20:45 UTC
Would it work for this to add a CSS rule:

.flow-post-content * { max-width: 100% !important; max-height: 600px !important; overflow: hidden; }
Comment 6 Shahyar Ghobadpour 2014-01-08 11:17:45 UTC
Andrew, without height: auto, img (with height attr) will not scale proportionally. This would be the CSS rule you're looking for:

.flow-post-content * {
    max-width: 100%;
    height: auto;
    word-wrap: break-word;
}


Though, I don't see this as a serious problem in the post content, since it seems to use overflow: scroll, preventing it from busting out. However, the topic title is currently susceptible to this issue.
Comment 7 Maryana Pinchuk 2014-02-09 23:10:34 UTC
Fix for 57962 fixed this in the short-term (though it also introduced some new weirdness...)

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links