Last modified: 2013-11-05 01:01:24 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T58271, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 56271 - Flow: links in Echo notifications should take you to the specific post
Flow: links in Echo notifications should take you to the specific post
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
Flow (Other open bugs)
master
All All
: Unprioritized normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
: 56297 (view as bug list)
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-10-28 20:06 UTC by spage
Modified: 2013-11-05 01:01 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description spage 2013-10-28 20:06:36 UTC
The Echo notification that someone has responded to your post is something like

http://ee-flow.wmflabs.org/w/index.php?title=User_talk:Violetto&workflow=05066a2f5f60b62ef835fa163e68c4ac&action[workflow]=05066a2f5f60b62ef835fa163e68c4ac

It takes you to the topic, but doesn't scroll down to your post. It should act like the permalink for the post that has replies, 

http://ee-flow.wmflabs.org/w/index.php?title=User_talk:Violetto&workflow=05066a2f5f60b62ef835fa163e68c4ac&action=view#flow-post-05066a2f5f6cb62ef835fa163e68c4ac

This scrolls down to your post and gives it the nice green highlight bar.  (It's more obvious on a big topic.)

The Echo link has the actual post as part of the query string&action[workflow]=<postID>, while the permalink has the actual post as a fragment, #flow-post-<postID>.  I think the latter is preferable.
Comment 1 spage 2013-10-29 07:44:52 UTC
The WMF core features team tracks this bug on Mingle card https://mingle.corp.wikimedia.org/projects/flow/cards/372, but people from the community are welcome to contribute here and in Gerrit.
Comment 2 Maryana Pinchuk 2013-10-29 17:26:07 UTC
*** Bug 56297 has been marked as a duplicate of this bug. ***
Comment 3 Maryana Pinchuk 2013-10-29 18:06:05 UTC
Just to clarify a bit, the primary target of a Flow reply notification ("Foo replied to your *post*", where *post* is a link) currently takes you to the post in isolation. This shouldn't happen except as a non-JS fallback. Both the primary target (*post*) and secondary target (the whole notification area) on these notifications should:

* take you to the topic and scroll you down to the post
* highlight the post

... e.g., the current permalink behavior.
Comment 4 Gerrit Notification Bot 2013-11-04 20:08:36 UTC
Change 93583 had a related patch set uploaded by Bsitu:
Post link in notification should take users to specific post

https://gerrit.wikimedia.org/r/93583
Comment 5 Gerrit Notification Bot 2013-11-05 00:58:54 UTC
Change 93583 merged by jenkins-bot:
Post link in notification should take users to specific post

https://gerrit.wikimedia.org/r/93583

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links