Last modified: 2013-11-08 15:37:17 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T58298, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 56298 - maintenance/cleanupUploadStash.php is broken (throws exception)
maintenance/cleanupUploadStash.php is broken (throws exception)
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
File management (Other open bugs)
unspecified
All All
: High normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-10-29 07:24 UTC by Faidon Liambotis
Modified: 2013-11-08 15:37 UTC (History)
7 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Faidon Liambotis 2013-10-29 07:24:40 UTC
I discovered today that the cleanupUploadStash.php job on terbium has been failing for a while and we've accumulated 5T of data in temp containers.

There was a "missing /a" issue that was breaking foreachwiki, which I worked around. However, when I run cleanupUploadStash.php now, I get the following exception for all wikis:

bswikibooks:  Getting list of files to clean up...
bswikibooks:  Removing 2 file(s)...
bswikibooks:  UploadStash::getFile No user is logged in, files must belong to users
bswikibooks:  Backtrace:
bswikibooks:  #0 /usr/local/apache/common-local/php-1.23wmf1/includes/upload/UploadStash.php(361): UploadStash->getFile('11jhstz7psnc.tykg19.954.jpg')
bswikibooks:  #1 /usr/local/apache/common-local/php-1.23wmf1/maintenance/cleanupUploadStash.php(83): UploadStash->removeFileNoAuth('11jhstz7psnc.tykg19.954.jpg')
bswikibooks:  #2 /usr/local/apache/common-local/php-1.23wmf1/maintenance/doMaintenance.php(113): UploadStashCleanup->execute()
bswikibooks:  #3 /usr/local/apache/common-local/php-1.23wmf1/maintenance/cleanupUploadStash.php(143): require_once('/usr/local/apache/common-local/php-1.23wmf1/maintenance/doMaintenance.php')
bswikibooks:  #4 /usr/local/apache/common-local/multiversion/MWScript.php(97): require_once('/usr/local/apache/common-local/php-1.23wmf1/maintenance/cleanupUploadStash.php')
bswikibooks:  #5 {main}
Comment 1 Kevin Israel (PleaseStand) 2013-10-29 08:10:45 UTC
This might have been broken by 8049aa338451, which added the $this->getFile( $key ) call without the "janky" $noAuth = true argument.
Comment 2 Gerrit Notification Bot 2013-10-29 15:59:28 UTC
Change 92542 had a related patch set uploaded by Anomie:
UploadStash::removeFileNoAuth shouldn't need auth

https://gerrit.wikimedia.org/r/92542
Comment 3 Gerrit Notification Bot 2013-10-29 16:00:52 UTC
Change 92543 had a related patch set uploaded by Reedy:
UploadStash::removeFileNoAuth shouldn't need auth

https://gerrit.wikimedia.org/r/92543
Comment 4 Gerrit Notification Bot 2013-10-29 16:01:16 UTC
Change 92544 had a related patch set uploaded by Reedy:
UploadStash::removeFileNoAuth shouldn't need auth

https://gerrit.wikimedia.org/r/92544
Comment 5 Gerrit Notification Bot 2013-10-29 16:01:36 UTC
Change 92545 had a related patch set uploaded by Reedy:
UploadStash::removeFileNoAuth shouldn't need auth

https://gerrit.wikimedia.org/r/92545
Comment 6 Gerrit Notification Bot 2013-10-29 16:04:56 UTC
Change 92542 merged by jenkins-bot:
UploadStash::removeFileNoAuth shouldn't need auth

https://gerrit.wikimedia.org/r/92542
Comment 7 Gerrit Notification Bot 2013-10-29 16:05:40 UTC
Change 92544 merged by Reedy:
UploadStash::removeFileNoAuth shouldn't need auth

https://gerrit.wikimedia.org/r/92544
Comment 8 Gerrit Notification Bot 2013-10-29 16:05:49 UTC
Change 92543 merged by Reedy:
UploadStash::removeFileNoAuth shouldn't need auth

https://gerrit.wikimedia.org/r/92543
Comment 9 Gerrit Notification Bot 2013-11-08 02:05:47 UTC
Change 92545 merged by MarkAHershberger:
UploadStash::removeFileNoAuth shouldn't need auth

https://gerrit.wikimedia.org/r/92545
Comment 10 Brad Jorsch 2013-11-08 15:37:17 UTC
I guess this bug is fixed now?

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links