Last modified: 2014-02-19 22:17:23 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T58300, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 56300 - Flow: edit single post link looks and works differently
Flow: edit single post link looks and works differently
Status: REOPENED
Product: MediaWiki extensions
Classification: Unclassified
Flow (Other open bugs)
master
All All
: Normal minor (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-10-29 07:42 UTC by spage
Modified: 2014-02-19 22:17 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description spage 2013-10-29 07:42:53 UTC
If I right-click on a post's pencil icon and open in new tab (or copy the link and paste it), the URL is like
<http://ee-flow.wmflabs.org/w/index.php?title=User_talk:Spage&topic[postId]=050803b2ffb50e132562fa163e68c4ac&workflow=05061628bfecb62ef835fa163e68c4ac&action=edit-post>

There are some issues with this
* page title doesn't say I'm editing
* no link back to the topic or to the board
* the Save button looks different, it is blue and says [Submit changes]
* after clicking this I see the updated post in context in its topic (good), but the timestamp on the post remains 10 hours ago

(editing posts in-place is broken on ee-flow right now, there may be other dissimilarities)

I'm giving this minor severity since normally you edit a post in-place within a topic; but unless we preclude viewing and acting on posts in isolation, it needs greater consistency.
Comment 1 spage 2013-10-29 07:45:50 UTC
The WMF core features team tracks this bug on Mingle card https://mingle.corp.wikimedia.org/projects/flow/cards/377, but people from the community are welcome to contribute here and in Gerrit.
Comment 2 Maryana Pinchuk 2013-10-29 17:37:13 UTC
I've definitely seen this before (with just the normal "click on pencil icon" editing, not even new-tabbing/link-following). I believe Matthias or Erik mentioned that this is the expected non-JS fallback behavior, so it's probably a case of Flow sporadically dropping JS on the floor.
Comment 3 Oliver Keyes 2013-10-29 17:39:28 UTC
https://www.youtube.com/watch?v=gAYL5H46QnQ
Comment 4 Maryana Pinchuk 2013-12-05 19:49:02 UTC
Not sure what/who fixed it, but it works fine now :)
Comment 5 spage 2014-01-27 10:07:45 UTC
You can still get to an action=edit-post URL if you right-click on a post's permalink icon, or if you have JavaScript disabled.

The current set of glitches is slightly different:

* page title doesn't say I'm editing
* no link back to the topic or to the board (this is "improve page navigation", https://trello.com/c/yal21Kkh/47-improve-page-navigation ) 
* no preview
* after clicking this I see the updated post in context in its topic (good),
but the timestamp on the post remains 10 hours ago
* I think we agreed a post should always be shown in context within its topic.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links