Last modified: 2014-10-08 18:12:41 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T58304, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 56304 - Bad Parsoid FLAC media handling (use FLAC instead of OGG)
Bad Parsoid FLAC media handling (use FLAC instead of OGG)
Status: NEW
Product: Parsoid
Classification: Unclassified
General (Other open bugs)
unspecified
All All
: Normal normal
: ---
Assigned To: Gabriel Wicke
:
Depends on:
Blocks: 37220
  Show dependency treegraph
 
Reported: 2013-10-29 10:08 UTC by Kelson [Emmanuel Engelhart]
Modified: 2014-10-08 18:12 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Kelson [Emmanuel Engelhart] 2013-10-29 10:08:55 UTC
Using the following code:
[[File:Hmv-db2291-32-4807-2wx766.flac]]

generates code with urls pointing to the flac file, but this should point to the ogg file (which is the version of the file which is adapted to the web).
Comment 1 Brion Vibber 2013-10-30 20:58:23 UTC
Parsoid probably shouldn't need to know details of media rendering, which is potentially infinitely extensible.

I would expect Parsoid to only deal with placeholders that actual media viewers get inserted into...
Comment 2 Gabriel Wicke 2013-10-30 21:02:53 UTC
(In reply to comment #1)
> Parsoid probably shouldn't need to know details of media rendering, which is
> potentially infinitely extensible.
> 
> I would expect Parsoid to only deal with placeholders that actual media
> viewers
> get inserted into...

Is there an API that we can call to get the current core media rendering for things that are not simple images? In the worst case we could probably abuse action=parse.

We have not given the desired semantic DOM structure for videos or sounds much thought yet. It would be tempting to use native video / audio html5 tags and let shims handle the fall-back for clients that don't support it.
Comment 3 Brion Vibber 2013-10-30 22:59:44 UTC
I have some ideas for creating a cleaner interface for this sort of thing; I'll write up some notes...
Comment 4 Brion Vibber 2013-10-31 09:07:06 UTC
Ok threw some quick notes up at https://www.mediawiki.org/wiki/User:Brion_VIBBER/Media_rendering_encapsulation
Comment 5 Gabriel Wicke 2013-10-31 17:57:05 UTC
(In reply to comment #4)
> Ok threw some quick notes up at
> https://www.mediawiki.org/wiki/User:Brion_VIBBER/
> Media_rendering_encapsulation

@Brion: Images are handled according to https://www.mediawiki.org/wiki/Parsoid/MediaWiki_DOM_spec#Images

For video / audio, my initial instinct would be to spec something similar using video and audio tags in a way that works directly on modern browsers, and let shims handle legacy clients.
Comment 6 Brion Vibber 2013-10-31 18:16:26 UTC
Yeah I started adding markup notes along those lines -- I'm a bit unclear on where all the media parameters end up though; particularly width and height *must* be retained and I think there may be some additional custom properties... images may include a page specifier (for DjVu, PDF, etc), and TimedMediaHandler items may have things like a start time.

I can certainly envision additional custom parameters on other types -- a 3d model viewer might have initial camera parameters or lighting setup, an animation may want to indicate that it should autoplay or loop (like animated GIFs do) as an alternative to non-autoplaying audio/video behavior.

How do we pass those through if Parsoid and VE don't know about them specifically?

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links