Last modified: 2014-11-20 14:32:20 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T58353, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 56353 - Script error mw.EmbedPlayerNative.js at line 0
Script error mw.EmbedPlayerNative.js at line 0
Status: PATCH_TO_REVIEW
Product: MediaWiki extensions
Classification: Unclassified
TimedMediaHandler (Other open bugs)
master
All All
: Low normal (vote)
: ---
Assigned To: Michael Dale
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-10-29 23:15 UTC by Siebrand Mazeland
Modified: 2014-11-20 14:32 UTC (History)
6 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Screenshots with observation (2.47 MB, image/png)
2013-12-17 10:49 UTC, Siebrand Mazeland
Details

Comment 1 Siebrand Mazeland 2013-10-29 23:16:03 UTC
Other information:
* OS: OSX 10.9
* Browser: Firefox 24
Comment 2 Andre Klapper 2013-10-31 17:55:55 UTC
Cannot reproduce, only relevant output I get for that URL and starting after pressing "Play" is:
[18:54:23.679] TypeError: vid is undefined @ https://bits.wikimedia.org/static-1.23wmf1/extensions/TimedMediaHandler/MwEmbedModules/EmbedPlayer/resources/mw.EmbedPlayerNative.js:473
Comment 3 Siebrand Mazeland 2013-12-17 10:49:13 UTC
Created attachment 14120 [details]
Screenshots with observation

(In reply to comment #2)
> Cannot reproduce, only relevant output I get for that URL and starting after
> pressing "Play" is:
> [18:54:23.679] TypeError: vid is undefined @
> https://bits.wikimedia.org/static-1.23wmf1/extensions/TimedMediaHandler/
> MwEmbedModules/EmbedPlayer/resources/mw.EmbedPlayerNative.js:473

1. What browser and operating system version was this report valid for?
2. Why did you set observed JavaScript errors and confusing notitications as low priority? From what I can tell, this signifies "we are not worried about this" (per https://www.mediawiki.org/wiki/Bugzilla/Fields#importance). Is that a correct interpretation?

Updated observations:
* Can still reproduce with Firefox 26 while logged on. Adding screenshot.
* In Chrome 31, I get the following JavaScript error (both logged on and logged off): Uncaught TypeError: Cannot read property 'readyState' of undefined. mw.EmbedPlayerNative.js:473
*
Comment 4 Andre Klapper 2013-12-17 11:59:19 UTC
It's low priority until somebody else can reproduce it, or until it happens with other testcases too. That's also why I set it unconfirmed (not reproduced by anybody else yet).

I'm running Firefox 25 on Fedora 20 when I tried again today; testing in comment 2 was Firefox 24 on Fedora 19, both being logged in.

I can confirm observations in comment 3 with Chrome 31 not being logged in on
https://commons.wikimedia.org/wiki/File:Nl-artritis.ogg?debug=true :

Uncaught TypeError: Cannot read property 'readyState' of undefined mw.EmbedPlayerNative.js:473
mw.EmbedPlayerNative.setCurrentTime mw.EmbedPlayerNative.js:473
(anonymous function) mw.MediaWikiPlayerSupport.js:257
Comment 5 Bawolff (Brian Wolff) 2013-12-17 17:56:54 UTC
I personally cannot reproduce (on firefox 3.5 and on google chrome Version 27.0.1453.81 beta, both on Linux)
Comment 6 Derk-Jan Hartman 2014-11-19 12:33:07 UTC
At the end of the play, this is triggered:

// dont show credits for audio elements,
// seek to begining instead
if( embedPlayer.isAudio() ){
	embedPlayer.setCurrentTime(0);
	return ;
}

Which then causes the reported error, because the <audio> element is no longer there, but the setCurrentTime() code expects it to be there.
Comment 7 Gerrit Notification Bot 2014-11-19 12:46:15 UTC
Change 174407 had a related patch set uploaded by TheDJ:
Fix undefined error on end of play of native <audio>

https://gerrit.wikimedia.org/r/174407
Comment 8 Gerrit Notification Bot 2014-11-20 14:31:27 UTC
Change 174407 merged by jenkins-bot:
Fix undefined error on end of play of native <audio>

https://gerrit.wikimedia.org/r/174407
Comment 9 Gilles Dubuc 2014-11-20 14:32:20 UTC
I could reproduce the JS error and Derk-Jan's changeset fixed it. Not sure if it was the original issue, though.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links