Last modified: 2013-12-02 21:54:42 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T58370, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 56370 - Login captcha shown after too many incorrect attempts to log in looks ugly


Summary:	Login captcha shown after too many incorrect attempts to log in looks ugly

Status:	RESOLVED FIXED

Product:	MediaWiki
Classification:	Unclassified
Component:	User login and signup (Other open bugs)
Version:	1.22.0
Hardware:	All All

Importance:	Low normal (vote)
Target Milestone:	1.23.0 release
Assigned To:	Nobody - You can work on this!

URL:	https://en.wikipedia.org/wiki/Special...
Whiteboard:	gci2013
Keywords:	easy

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2013-10-30 11:08 UTC by Bartosz Dziewoński
Modified:	2013-12-02 21:54 UTC (History)
CC List:	4 users (show)

See Also:
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
Login captcha (in Polish) (28.43 KB, image/png) 2013-10-30 11:08 UTC, Bartosz Dziewoński	Details
Signup captcha (in Polish), for comparison (24.07 KB, image/png) 2013-11-12 14:25 UTC, Bartosz Dziewoński	Details
Add an attachment (proposed patch, testcase, etc.)

Description Bartosz Dziewoński 2013-10-30 11:08:05 UTC

Created attachment 13628 [details]
Login captcha (in Polish)

Login captcha shown after too many incorrect attempts to log in looks ugly, compared to the nicely styles create account form captcha.

Comment 1 Andre Klapper 2013-11-12 13:19:21 UTC

Do you refer to the capture itself? Or the red box?

Comment 2 Bartosz Dziewoński 2013-11-12 14:25:45 UTC

Created attachment 13770 [details]
Signup captcha (in Polish), for comparison

I refer to the stuff above the red box. It's not styled consistenyl wirh the rest of the form. I attached similar captcha on the signup form for comparison.

Comment 3 Bartosz Dziewoński 2013-11-15 23:21:51 UTC

The signup captcha is being reformatted by a script in mediawiki.special.createAccount.js; we should probably run it for login too. 
(Also, that's an awful solution. :( )

Comment 4 Gerrit Notification Bot 2013-12-01 01:20:27 UTC

Change 98357 had a related patch set uploaded by Jcf2000:
Reformat signin captcha in case of incorrect login

https://gerrit.wikimedia.org/r/98357

Comment 5 Tyler Romeo 2013-12-01 05:58:30 UTC

I'm assuming this bug is meant for Extension:ConfirmEdit, since that's where CAPTCHA support is.

Comment 6 Bartosz Dziewoński 2013-12-01 12:18:03 UTC

Actually the code to format CAPTCHA to look pretty in the new login/signup form is currently in core (which sucks, feel free to fix that).

Comment 7 Tyler Romeo 2013-12-01 19:04:34 UTC

Ha! Never knew that. Interesting.

Comment 8 Bartosz Dziewoński 2013-12-02 13:32:25 UTC

Fixed :)

http://www.google-melange.com/gci/task/view/google/gci2013/5893919866880000

Comment 9 Gerrit Notification Bot 2013-12-02 13:35:58 UTC

Change 98357 merged by jenkins-bot:
Additional styling for CAPTCHA on Special:UserLogin

https://gerrit.wikimedia.org/r/98357

Comment 10 Steven Walling 2013-12-02 21:54:42 UTC

(In reply to comment #8)
> Fixed :)
> 
> http://www.google-melange.com/gci/task/view/google/gci2013/5893919866880000

This looks great. Nice work everyone.

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links