Last modified: 2013-10-30 21:12:43 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T58389, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 56389 - default labs MediaWiki config will generate https links
default labs MediaWiki config will generate https links
Status: NEW
Product: Wikimedia Labs
Classification: Unclassified
Infrastructure (Other open bugs)
unspecified
All All
: Unprioritized normal
: ---
Assigned To: Ryan Lane
http://toro.wmflabs.org/wiki/Special:...
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-10-30 21:12 UTC by spage
Modified: 2013-10-30 21:12 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description spage 2013-10-30 21:12:43 UTC
The Puppet templates/labs-localsettings has
if ( array_key_exists( "SERVER_NAME", $_SERVER ) ) {
    $wgServer = "//" . $_SERVER["SERVER_NAME"];
}

Because $wgServer is not prefixed with http:, MediaWiki thinks https://servername links will work, thus several places in the code generate them, e.g. Special:UserLogin's _Use secure connection_ link and Echo notification e-mails. But most labs instances don't have working SSL, even via instance-proxy.wmflabs.org/

Project admins can't override this in orig/LocalSettings.php because these lines come after it is require_once'd.

Ideally the puppet LocalSettings would determine if https worked to the labs instance, and if not set
   $wgServer= 'http://' . $_SERVER['SERVER_NAME'];

Possible workarounds include unset ($_SERVER['REQUEST_TIME'] ),  overwriting $wgServer in some later config hook, and configuring SSL on the labs instance (bug 54065).

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links