Last modified: 2013-12-04 19:59:28 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T58401, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 56401 - cleanupUploadStash.php broken: key not found in stash
cleanupUploadStash.php broken: key not found in stash
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
File management (Other open bugs)
1.23.0
All All
: High normal (vote)
: ---
Assigned To: aarcos.wiki
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-10-31 00:18 UTC by Faidon Liambotis
Modified: 2013-12-04 19:59 UTC (History)
6 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Faidon Liambotis 2013-10-31 00:18:45 UTC
cleanupUploadStash.php is still broken:

apache@terbium:~$ php -ddisplay_errors=On /a/common/multiversion/MWScript.php maintenance/cleanupUploadStash.php --wiki=commonswiki
Getting list of files to clean up...
Removing 79838 file(s)...
Failed removing stashed upload with key: 10uw2z437hfo.dim94n.283617.
Failed removing stashed upload with key: 10uw2zf3neeg.jxzu5v.283617.
Failed removing stashed upload with key: 116rxtp3nhgo.fqtt50.307998.
Failed removing stashed upload with key: 117pxjmwy61o.tfky8u.2578985.
Failed removing stashed upload with key: 1181tn5e654s.bamzbw.1761492.jpg
Failed removing stashed upload with key: 1181tn4pj71g.nj3yzx.1761492.jpg
Failed removing stashed upload with key: 1181tn6rjxr0.j9d4y3.1761492.jpg
Failed removing stashed upload with key: 118h4wswdahw.ou3eal.2654023.jpg
Failed removing stashed upload with key: 11e66f8ogpy0.i88nzn.932010.
Failed removing stashed upload with key: 11e6ckgs39z0.d6u7e8.932010.
key '11qua1h4zlz4.fkvawj.2212319.jpg' not found in stash
Backtrace:
#0
/usr/local/apache/common-local/php-1.23wmf1/maintenance/cleanupUploadStash.php(82):
UploadStash->getFile('11qua1h4zlz4.fkvawj.2212319.jpg', true)
#1
/usr/local/apache/common-local/php-1.23wmf1/maintenance/doMaintenance.php(113):
UploadStashCleanup->execute()
#2
/usr/local/apache/common-local/php-1.23wmf1/maintenance/cleanupUploadStash.php(143):
require_once('/usr/local/apache/common-local/php-1.23wmf1/maintenance/doMaintenance.php')
#3 /usr/local/apache/common-local/multiversion/MWScript.php(97):
require_once('/usr/local/apache/common-local/php-1.23wmf1/maintenance/cleanupUploadStash.php')
#4 {main}


(note the missing extensions)

Additionally, as Aaron pointed out, the code doesn't catch all exceptions, namely UploadStashException, which makes the script right after the above and not proceed with the rest of the files.
Comment 1 Gerrit Notification Bot 2013-11-04 17:40:35 UTC
Change 93505 had a related patch set uploaded by Aaron Schulz:
Catch all stash errors in cleanup script

https://gerrit.wikimedia.org/r/93505
Comment 2 Gerrit Notification Bot 2013-11-04 17:51:16 UTC
Change 93505 merged by jenkins-bot:
Catch all stash errors in cleanup script

https://gerrit.wikimedia.org/r/93505
Comment 3 Gerrit Notification Bot 2013-11-04 17:51:19 UTC
Change 93506 had a related patch set uploaded by Aaron Schulz:
Catch all stash errors in cleanup script

https://gerrit.wikimedia.org/r/93506
Comment 4 Gerrit Notification Bot 2013-11-04 18:15:04 UTC
Change 93506 merged by jenkins-bot:
Catch all stash errors in cleanup script

https://gerrit.wikimedia.org/r/93506
Comment 5 db [inactive,noenotif] 2013-12-04 19:59:28 UTC
code clean up was merged

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links