Last modified: 2014-08-25 18:05:56 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T58402, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 56402 - Exit lightbox when clicking on backdrop
Exit lightbox when clicking on backdrop
Status: RESOLVED WONTFIX
Product: MediaWiki extensions
Classification: Unclassified
MultimediaViewer (Other open bugs)
unspecified
All All
: Low enhancement (vote)
: ---
Assigned To: Tony Thomas
: easy
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-10-31 00:21 UTC by Mark Holmquist
Modified: 2014-08-25 18:05 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Mark Holmquist 2013-10-31 00:21:29 UTC
Suggestion from legoktm - should be fairly easy.
Comment 1 Quiddity 2013-10-31 22:08:20 UTC
Suggestion from moi!  ;p   <3
Comment 2 MZMcBride 2013-12-25 00:09:56 UTC
(In reply to comment #0)
> Suggestion from legoktm - should be fairly easy.

Please use comment 0, also known as the bug description, to describe the bug.
Comment 3 Tony Thomas 2013-12-26 17:31:59 UTC
@Mark: Please elaborate the same so that someone can work on it please.
Comment 4 Mark Holmquist 2013-12-26 18:10:44 UTC
Sorry! The idea is, if someone clicks on the black area behind the image, the lightbox should close. There are already close methods that are fairly general, so the only work involved *should* be adding an event listener in the right spot, and clearing it properly.

Let me know if you need any help :)
Comment 5 Gerrit Notification Bot 2013-12-27 06:35:03 UTC
Change 103902 had a related patch set uploaded by 01tonythomas:
Exit Lightbox when clicked on backdrop

https://gerrit.wikimedia.org/r/103902
Comment 6 Gerrit Notification Bot 2014-01-19 10:15:20 UTC
Change 108317 had a related patch set uploaded by 01tonythomas:
Exit Lightbox when clicked on backdrop

https://gerrit.wikimedia.org/r/108317
Comment 7 Gerrit Notification Bot 2014-01-19 10:16:27 UTC
Change 103902 abandoned by 01tonythomas:
Exit Lightbox when clicked on backdrop

Reason:
persistent rebase errors 
Continued in 
https://gerrit.wikimedia.org/r/#/c/108317/

https://gerrit.wikimedia.org/r/103902
Comment 8 Gerrit Notification Bot 2014-02-02 10:56:33 UTC
Change 108317 merged by jenkins-bot:
Exit Lightbox when clicked on backdrop

https://gerrit.wikimedia.org/r/108317
Comment 9 Tony Thomas 2014-03-14 05:16:45 UTC
Looks like the patch was lost after 
https://gerrit.wikimedia.org/r/#/c/116921/
Reverting bug to open
Comment 10 Gerrit Notification Bot 2014-03-14 05:56:42 UTC
Change 118667 had a related patch set uploaded by 01tonythomas:
Exit Lightbox when clicked on Backdrop

https://gerrit.wikimedia.org/r/118667
Comment 11 Mark Holmquist 2014-03-14 16:06:50 UTC
For good reason.

We decided that this causes way too many accidental lightbox close events, and reverted.

WONTFIXing for now - we may revisit this later, but it won't be for the next few months.
Comment 12 Gerrit Notification Bot 2014-08-25 18:05:56 UTC
Change 118667 abandoned by MarkTraceur:
Exit Lightbox when clicked on Backdrop

Reason:
We tried doing this once before, it was just confusing and overall interfered with other actions in the viewer.

https://gerrit.wikimedia.org/r/118667

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links