Last modified: 2013-11-02 00:20:18 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T58489, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 56489 - Parsoid: [REGRESSION] content attribute missing from defaultsort tags
Parsoid: [REGRESSION] content attribute missing from defaultsort tags
Status: RESOLVED FIXED
Product: Parsoid
Classification: Unclassified
General (Other open bugs)
unspecified
All All
: Unprioritized normal
: ---
Assigned To: Gabriel Wicke
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-11-01 20:26 UTC by Roan Kattouw
Modified: 2013-11-02 00:20 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Roan Kattouw 2013-11-01 20:26:55 UTC
Before https://gerrit.wikimedia.org/r/#/c/90449 :

<meta property="mw:PageProp/categorydefaultsort" content="Page, Main" data-parsoid='{"src":"{{DEFAULTSORT:Page, Main}}","dsr":[1800,1826,null,null]}'/>

After:

<meta property="mw:PageProp/categorydefaultsort" data-parsoid='{"src":"{{DEFAULTSORT:Page, Main}}","a":{"content":null},"sa":{"content":"Page, Main"},"dsr":[1800,1826,null,null]}'/>

This breaks editing of defaultsort in VisualEditor for obvious reasons, but it also triggers a failure mode in VisualEditor where missing content attributes aren't expected and are normalized to content="null", triggering corruption warnings and changing {{DEFAULTSORT:Foo}} to {{DEFAULTSORT:null}}. I'll fix that in VE.
Comment 1 Gerrit Notification Bot 2013-11-01 21:30:11 UTC
Change 93108 had a related patch set uploaded by GWicke:
Bug 56489: Allow content attribute on parsoid-generated meta tokens

https://gerrit.wikimedia.org/r/93108
Comment 2 Gerrit Notification Bot 2013-11-01 21:48:29 UTC
Change 93108 merged by jenkins-bot:
Bug 56489: Allow content attribute on parsoid-generated meta tokens

https://gerrit.wikimedia.org/r/93108

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links