Last modified: 2014-02-12 18:12:01 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T58494, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 56494 - Media info/tool links positioning inconsistent depending on presence of description
Media info/tool links positioning inconsistent depending on presence of descr...
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
MultimediaViewer (Other open bugs)
unspecified
All All
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
https://test.wikipedia.org/wiki/Light...
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-11-01 23:06 UTC by Brion Vibber
Modified: 2014-02-12 18:12 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Brion Vibber 2013-11-01 23:06:29 UTC
Go to <https://test.wikipedia.org/wiki/Lightbox_demo> and click on the sunrise image -- you'll see that at the bottom of the lightbox a description appears on the left, and some info & links on the right.

But if you click on the aerial view of San Francisco, there's no description, and the info & links appear on the *left* instead of the right.

I would expect the links to be consistently positioned on the right.
Comment 1 Fabrice Florin 2013-11-04 23:50:44 UTC
Thanks, Brion.

You are correct, the links in the lower right hand side of the light box should always remain in the same place.

The fact that there is no description for that file should not change the layout of Media Viewer. Instead, it should simply say 'No description.', as requested in a related bug.

Our designer Pau Giner is working on a new layout that might make things less strange if a description is missing, too short or too long.
Comment 2 Mark Holmquist 2013-11-20 01:15:50 UTC
I believe this got fixed when we made the description div scrollable and fixed its positioning (as well as that of the metadata list element), so we should be better now. Reopen if not.
Comment 3 Tisza Gergő 2013-11-20 11:10:03 UTC
The div is display:none-ed when empty, so this still happens.
Comment 4 Gerrit Notification Bot 2013-11-20 11:10:35 UTC
Change 96465 had a related patch set uploaded by Gergő Tisza:
Preserve space for the description even if it is not present

https://gerrit.wikimedia.org/r/96465
Comment 5 Gerrit Notification Bot 2013-11-20 19:17:00 UTC
Change 96465 merged by jenkins-bot:
Preserve space for the description even if it is not present

https://gerrit.wikimedia.org/r/96465
Comment 6 Andre Klapper 2014-02-12 16:21:47 UTC
Patch was merged a while ago - is there more work left to do here (if yes: please reset the bug report status to NEW or ASSIGNED), or can you close this ticket as RESOLVED FIXED?
Comment 7 Tisza Gergő 2014-02-12 18:12:01 UTC
Fixed. We have placeholder text now when there is no description.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links