Last modified: 2014-02-14 00:00:31 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T58501, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 56501 - 'Use this file' dialog can be popped up multiple times


Summary:	'Use this file' dialog can be popped up multiple times

Status:	RESOLVED FIXED

Product:	MediaWiki extensions
Classification:	Unclassified
Component:	MultimediaViewer (Other open bugs)
Version:	unspecified
Hardware:	All All

Importance:	Normal normal (vote)
Target Milestone:	---
Assigned To:	Theopolisme

URL:	https://test.wikipedia.org/wiki/Light...
Whiteboard:	gci2013
Keywords:	easy

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2013-11-01 23:24 UTC by Brion Vibber
Modified:	2014-02-14 00:00 UTC (History)
CC List:	4 users (show)

See Also:
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
screenshot with multiple dialogs (588.66 KB, image/png) 2013-11-01 23:24 UTC, Brion Vibber	Details
Add an attachment (proposed patch, testcase, etc.)

Description Brion Vibber 2013-11-01 23:24:16 UTC

Created attachment 13667 [details]
screenshot with multiple dialogs

The 'use this file' dialog doesn't prevent clicks from going through to underlying UI, including the link that pops up the dialog in the first place -- you can actually pop up multiple copies.

Comment 1 Mark Holmquist 2013-11-20 01:15:59 UTC

I guess the "best" way to do this would be to set a flag and make sure the flag is false before we open the dialog, then reset it on close.

Not that hard, maybe useful for a new contributor :)

Comment 2 Quim Gil 2013-11-28 05:35:35 UTC

A Google Code-in student has claimed this task:

http://www.google-melange.com/gci/task/view/google/gci2013/5830951351353344

Comment 3 Gerrit Notification Bot 2013-11-28 05:44:41 UTC

Change 98066 had a related patch set uploaded by Theopolisme:
Prevent multiple "Use this file" windows

https://gerrit.wikimedia.org/r/98066

Comment 4 Gerrit Notification Bot 2013-11-29 21:19:15 UTC

Change 98066 merged by jenkins-bot:
Prevent multiple "Use this file" windows

https://gerrit.wikimedia.org/r/98066

Comment 5 Andre Klapper 2014-02-13 23:59:53 UTC

Assuming this bug is FIXED by the patch merged in comment 4.
If that is not the case: Please reopen and elaborate what is left to do here to get this report fixed.

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links