Last modified: 2014-02-10 21:43:21 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T58574, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 56574 - Rollback notification doesn't check if it was a null revert
Rollback notification doesn't check if it was a null revert
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
Echo (Other open bugs)
unspecified
All All
: Unprioritized normal (vote)
: ---
Assigned To: Alex Monk
https://en.wikipedia.org/w/index.php?...
: easy
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2013-11-04 18:16 UTC by Kunal Mehta (Legoktm)
Modified: 2014-02-10 21:43 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Kunal Mehta (Legoktm) 2013-11-04 18:16:43 UTC 
The revert notification is triggered even if the rollback does nothing (current version is equal to the one being reverted to).

Just need to check that the content of both revisions are not equal before sending the notification.
Comment 1 Gerrit Notification Bot 2013-11-16 19:25:07 UTC 
Change 95797 had a related patch set uploaded by Alex Monk:
Don't send rollback notification if nothing changed

https://gerrit.wikimedia.org/r/95797
Comment 2 Gerrit Notification Bot 2013-11-23 06:37:20 UTC 
Change 95797 merged by jenkins-bot:
Don't send rollback notification if nothing changed

https://gerrit.wikimedia.org/r/95797
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links