Last modified: 2014-04-20 19:16:18 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T58592, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 56592 - "Printable version" (printable=yes) has desktop styles on Vector
"Printable version" (printable=yes) has desktop styles on Vector
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Interface (Other open bugs)
1.23.0
All All
: High normal (vote)
: 1.23.0 release
Assigned To: Bartosz Dziewoński
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-11-04 22:54 UTC by Matt Walker
Modified: 2014-04-20 19:16 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Page with desktop footer (160.28 KB, image/png)
2013-11-04 22:54 UTC, Matt Walker
Details

Description Matt Walker 2013-11-04 22:54:25 UTC
Created attachment 13699 [details]
Page with desktop footer

When viewing a page with printable=true; the page footer is rendered as in the desktop view. Screenshot of https://en.wikipedia.org/w/index.php?title=Marathon_de_La_Rochelle&printable=yes&debug=true attached.
Comment 1 Matt Walker 2013-11-04 22:54:52 UTC
Possibly related to https://bugzilla.wikimedia.org/show_bug.cgi?id=56366
Comment 2 Bartosz Dziewoński 2013-11-04 23:01:38 UTC
Definitely. The way it was fixed, the print styles are only applied during actual printing (or "native" print preview), not with printable=yes.
Comment 3 Bartosz Dziewoński 2013-11-06 14:29:41 UTC
(Note that when actually printed, the footer behaves as it should. Appropriate @media rules are defined outside of ResourceLoader's jurisdiction, so it can't rewrite them for printable=yes version.)
Comment 4 Bartosz Dziewoński 2014-04-18 13:57:57 UTC
This looks a lot worse now after the typography refresh. We really should just do the media queries for Vector the standard way.
Comment 5 Gerrit Notification Bot 2014-04-18 14:36:31 UTC
Change 127248 had a related patch set uploaded by Bartosz Dziewoński:
vector: Do styles the ResourceLoader way

https://gerrit.wikimedia.org/r/127248
Comment 6 Gerrit Notification Bot 2014-04-18 23:28:10 UTC
Change 127248 merged by jenkins-bot:
vector: Do styles the ResourceLoader way

https://gerrit.wikimedia.org/r/127248
Comment 7 Gerrit Notification Bot 2014-04-20 12:49:08 UTC
Change 127474 had a related patch set uploaded by Bartosz Dziewoński:
vector: Do styles the ResourceLoader way

https://gerrit.wikimedia.org/r/127474
Comment 8 Bartosz Dziewoński 2014-04-20 12:50:50 UTC
Backported to 1.23 release.
Comment 9 Bartosz Dziewoński 2014-04-20 13:50:31 UTC
Not actually backported yet because jenkins has issues, ugh.
Comment 10 Gerrit Notification Bot 2014-04-20 19:07:05 UTC
Change 127474 merged by jenkins-bot:
vector: Do styles the ResourceLoader way

https://gerrit.wikimedia.org/r/127474
Comment 11 Bartosz Dziewoński 2014-04-20 19:16:18 UTC
Right.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links