Last modified: 2014-01-21 22:23:33 UTC
Created attachment 13705 [details] Screenshot of the email options in MWpreferences. Email and Email confirmation options(which are optionals) in MW preferences should not be given in red boxes which generally indicates error message.
The Email conformation box is ok to be in red, but the email input box need not be.
The classes which set those colors are .mw-email-not-authenticated and .mw-email-none. This will probably require some simple, but careful adjustments in their definitions in mediawiki.special.preferences.css and/or where they're added to the page in Preferences.php.
I plan to work on this bug. Kindly do assign me this bug.
Created attachment 13714 [details] Changed the red boxed email and email confirmation options In MW preferences, email and email confirmation options were given in red boxes indicating error message.In this attachment the red color is removed and the outline color is also changed from red.
Created attachment 13715 [details] Changed the red boxed email and email confirmation options In MW preferences, email and email confirmation options were given in red boxes indicating error message.In this attachment the red color is removed and the outline color is also changed from red. //The last patch was incomplete.
Change 93981 had a related patch set uploaded by Gerrit Patch Uploader: Changed the red boxed email and email confirmation options https://gerrit.wikimedia.org/r/93981
Created attachment 13718 [details] Changed the red boxed email and email confirmation options In MW preferences, email and email confirmation options were given in red boxes indicating error message.In this attachment the red color is removed and the outline color is also changed from red.
Please upload updated patches to Gerrit if possible. Please see http://www.mediawiki.org/wiki/Gerrit/Tutorial for how to do so. We do not use Bugzilla to review patches at all.
Change 94117 had a related patch set uploaded by Gerrit Patch Uploader: Changed the red boxed email and email confirmation options https://gerrit.wikimedia.org/r/94117
The second box (Email conformation section) is display when its half done (email entered but not confirmed) so it should probably still be countered as a error and displayed as such.
Change 93981 abandoned by Bartosz Dziewoński: Changed the red boxed email and email confirmation options Reason: Superseded by https://gerrit.wikimedia.org/r/94117 . You should submit new patchsets to existing changesets instead of new ones. https://gerrit.wikimedia.org/r/93981
See also : https://gerrit.wikimedia.org/r/#/c/94117/
p858snake: I have considered your suggestion and submitted my new patch.
I'm not really convinced red (actually pinkish) is bad here. This is only for non-authenticated emails. We *want* to catch their attention. They lose important functionality, including password reset, if they don't confirm their email. CCing Jared for UX feedback.
Actually, if I'm reading the code right, you don't need to confirm your email for password reset. However, if it's not confirmed, you might have mistyped it, in which case you still effectively won't be able to reset.
Can someone upload a screenshot of the proposed change, rather than just the code changed.
Created attachment 14338 [details] Screenshot of proposed change Screenshot of the proposed change that shows that only email not authenticated option should be highlighted red as an error.
I'm fine with this change, but the one thing we lose is the correlation between the "error" and the email associated with it. Can we change the text to "Your email address, $emailaddress is not yet confirmed. You will not receive email notification until you confirm this address."
Small correction "Your email address, $emailaddress is not yet confirmed. You will not receive email notifications until you confirm this address."
