Last modified: 2013-11-20 15:10:53 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T58623, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 56623 - Failed to get claim from claim Serialization after a reference is added using wbsetreference
Failed to get claim from claim Serialization after a reference is added using...
Status: VERIFIED FIXED
Product: MediaWiki extensions
Classification: Unclassified
WikidataRepo (Other open bugs)
unspecified
All All
: High normal (vote)
: ---
Assigned To: Wikidata bugs
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-11-05 17:44 UTC by Addshore
Modified: 2013-11-20 15:10 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Addshore 2013-11-05 17:44:46 UTC
Reported on https://www.wikidata.org/wiki/Wikidata:Contact_the_development_team#Strange_error_message

When trying to edit the claim value for a calim that has had a reference added through wbsetreference we get the error message

"Failed to get claim from claim Serialization If a hash is present in a reference serialization it needs to be correct"

It appears something is wrong with the hash which makes it uneditable?
Comment 1 Addshore 2013-11-05 17:47:46 UTC
As far as I can tell / guess this is caused by the change in the date in the reference which can be seen at http://www.diffchecker.com/b04b7pee

The date changing from "time":"+00000002013-10-18T17:21:07Z", to "time":"+00000002013-10-18T00:00:00Z",  seems to make the claim editable again?

per testing on https://www.wikidata.org/wiki/Q15078282
Comment 2 Addshore 2013-11-05 18:40:55 UTC
So, to update the bug it looks like around 40,000 claims are affected by this per the conversation on Contact the Dev Team.
This will be the claims for P141 created by SuccuBot https://www.wikidata.org/wiki/Special:WhatLinksHere/Property:P141
These can be fixed by simply passing in a new date.

Of course there is still something in the code of wbsetreferece / the validators parsers etc that needs to be fixed to stop this happening in the future..
Comment 3 Addshore 2013-11-06 10:25:11 UTC
Can reproduce on master with

https://www.wikidata.org/wiki/Special:ApiSandbox#action=wbsetreference&format=json&statement=Q4115189$ff893c9e-4c9b-d34e-fb74-f40a8e5e38ea&snaks={       "P248":[          {             "snaktype":"value",             "property":"P248",             "datavalue":{                "value":{                   "entity-type":"item",                   "numeric-id":15043677                },                "type":"wikibase-entityid"             }          }       ],       "P627":[          {             "snaktype":"value",             "property":"P627",             "datavalue":{                "value":"106003204",                "type":"string"             }          }       ],       "P813":[          {             "snaktype":"value",             "property":"P813",             "datavalue":{                "value":{                   "time":"+00000002013-10-05T15:24:21Z",                   "timezone":0,                   "before":0,                   "after":0,                   "precision":11,                   "calendarmodel":"http://www.wikidata.org/entity/Q1985727"                },                "type":"time"             }          }       ]    }&summary=test&token=TOKEN
Comment 4 Gerrit Notification Bot 2013-11-06 11:16:33 UTC
Change 93944 had a related patch set uploaded by Addshore:
Add validation for wbsetreference....

https://gerrit.wikimedia.org/r/93944
Comment 5 Gerrit Notification Bot 2013-11-07 15:37:40 UTC
Change 93944 merged by jenkins-bot:
ReAdd validation for wbsetreference....

https://gerrit.wikimedia.org/r/93944
Comment 6 Gerrit Notification Bot 2013-11-07 15:38:13 UTC
Change 94141 had a related patch set uploaded by Addshore:
ReAdd validation for wbsetreference....

https://gerrit.wikimedia.org/r/94141
Comment 7 Gerrit Notification Bot 2013-11-07 18:00:25 UTC
Change 94141 merged by Aude:
ReAdd validation for wbsetreference....

https://gerrit.wikimedia.org/r/94141
Comment 8 Gerrit Notification Bot 2013-11-07 19:03:27 UTC
Change 94180 had a related patch set uploaded by Aude:
Update Wikibase, fixes issues with references caught by selenium tests

https://gerrit.wikimedia.org/r/94180
Comment 9 Gerrit Notification Bot 2013-11-07 19:06:32 UTC
Change 94180 merged by Reedy:
Update Wikibase, fixes issues with references caught by selenium tests

https://gerrit.wikimedia.org/r/94180

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links