Last modified: 2013-11-06 09:55:55 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T58633, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 56633 - Preference retrieval should not require so much parsing
Preference retrieval should not require so much parsing
Status: NEW
Product: MediaWiki
Classification: Unclassified
User preferences (Other open bugs)
1.23.0
All All
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
: performance
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-11-05 20:54 UTC by Aaron Schulz
Modified: 2013-11-06 09:55 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Aaron Schulz 2013-11-05 20:54:27 UTC
Currently just fetching user options on Commons is slow due to a slow template in the gadget descriptions section. This actually causes deadlocks in ApiOptions when the watchlist token has to be created, the slow parsing happens, and then the actual preferences update happens. This is all pointless, since the API doesn't need those checkbox labels anyway...

One can profile this using eval.php on commons using:

Profiler::setInstance( new ProfilerSimpleText( array() ) ); Profiler::instance()->setTemplated( true );
$preferences = array();
var_dump( GadgetHooks::getPreferences( $wgUser, $preferences ) );
wfLogProfilingData();

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links