Last modified: 2014-05-01 23:49:29 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T58645, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 56645 - VisualEditor: Math inspector does not check type of node it's inspecting
VisualEditor: Math inspector does not check type of node it's inspecting
Status: VERIFIED FIXED
Product: VisualEditor
Classification: Unclassified
Editing Tools (Other open bugs)
unspecified
All All
: High normal
: VE-deploy-2014-04-24
Assigned To: Ed Sanders
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-11-06 00:35 UTC by Rummana Yasmeen
Modified: 2014-05-01 23:49 UTC (History)
8 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Link inspector and Math inspector together (55.00 KB, image/png)
2013-11-06 00:35 UTC, Rummana Yasmeen
Details
Errors and blank inspector (117.78 KB, image/png)
2014-04-16 23:45 UTC, Rummana Yasmeen
Details

Description Rummana Yasmeen 2013-11-06 00:35:19 UTC
Created attachment 13712 [details]
Link inspector and Math inspector together

Steps to reproduce:

1.Click on the Edit beta
2.Add a media such as image
3.Now open the Math inspector from More>Latex

Observed Result:
The Math inspector does not open,Now if you click on link both the inspectors open together.

See the screenshot attached.
Comment 1 Roan Kattouw 2013-11-06 01:06:54 UTC
At least one issue here is that MWExtensionInspector and MWMathInspector don't check that this.focusedNode is actually of the right type before doing things, so the math inspector will happily inspect references etc.

I couldn't reproduce the double inspector offhand.
Comment 2 Roan Kattouw 2013-11-06 01:11:32 UTC
(In reply to comment #1)
> I couldn't reproduce the double inspector offhand.
I can now:
1. Insert an image
2. Unselect and reselect the image so just the image is selected
3. Open the math inspector. It attempts to inspect the image and crashes
4. Post-crash, you get the double inspector thing
Comment 3 Roan Kattouw 2013-11-06 01:12:22 UTC
Both issues caused by the math inspector not checking that what it's inspecting is really a math node, changing summary.
Comment 4 Rummana Yasmeen 2014-04-16 23:44:30 UTC
It also throws the following errors and the math inspector gets completely blank.:
Uncaught TypeError: Cannot call method 'getAttribute' of null VM977:417
Uncaught TypeError: Cannot call method 'getOuterRange' of null
Comment 5 Rummana Yasmeen 2014-04-16 23:45:00 UTC
Created attachment 15126 [details]
Errors and blank inspector
Comment 6 James Forrester 2014-04-17 00:33:19 UTC
Fixed in Gerrit change #125933.
Comment 7 Rummana Yasmeen 2014-04-21 21:04:53 UTC
Verified the fix on Betalabs
Comment 8 Rummana Yasmeen 2014-04-30 23:00:56 UTC
Verified the fix on test2
Comment 9 Rummana Yasmeen 2014-05-01 23:49:29 UTC
Verified the fix on production

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links