Last modified: 2013-11-07 22:23:27 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T58726, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 56726 - "Unlock further protect options" doesn't work due to JS deprecations
"Unlock further protect options" doesn't work due to JS deprecations
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
JavaScript (Other open bugs)
1.22.0
All All
: Unprioritized normal (vote)
: 1.22.0 release
Assigned To: Krinkle
https://test.wikipedia.org/wiki/Page3...
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2013-11-07 17:03 UTC by Brad Jorsch
Modified: 2013-11-07 22:23 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Brad Jorsch 2013-11-07 17:03:34 UTC 
At least one core caller of the to-be-deprecated functions was missed before Gerrit change #92457 was merged: skins/common/protect.js (line 42) calls addClickHandler. Now that addClickHandler is nooped, clicking the checkbox no longer changes the form state.
Comment 1 Brad Jorsch 2013-11-07 17:05:43 UTC 
I also see some calls to injectSpinner and removeSpinner in ./skins/common/upload.js.
Comment 2 Gerrit Notification Bot 2013-11-07 17:35:35 UTC 
Change 94161 had a related patch set uploaded by Krinkle:
Migrate usage of legacy wikibits in core

https://gerrit.wikimedia.org/r/94161
Comment 3 Gerrit Notification Bot 2013-11-07 18:09:30 UTC 
Change 94161 merged by jenkins-bot:
Migrate usage of wikibits in legacy protect.js and upload.js

https://gerrit.wikimedia.org/r/94161
Comment 4 Gerrit Notification Bot 2013-11-07 20:52:49 UTC 
Change 94235 had a related patch set uploaded by Anomie:
Migrate usage of wikibits in legacy protect.js and upload.js

https://gerrit.wikimedia.org/r/94235
Comment 5 Gerrit Notification Bot 2013-11-07 20:53:15 UTC 
Change 94236 had a related patch set uploaded by Anomie:
Migrate usage of wikibits in legacy protect.js and upload.js

https://gerrit.wikimedia.org/r/94236
Comment 6 Gerrit Notification Bot 2013-11-07 21:07:09 UTC 
Change 94235 merged by jenkins-bot:
Migrate usage of wikibits in legacy protect.js and upload.js

https://gerrit.wikimedia.org/r/94235
Comment 7 Gerrit Notification Bot 2013-11-07 21:08:42 UTC 
Change 94236 merged by jenkins-bot:
Migrate usage of wikibits in legacy protect.js and upload.js

https://gerrit.wikimedia.org/r/94236
Comment 8 Brad Jorsch 2013-11-07 21:24:41 UTC 
Change merged, backported to wmf branches, and deployed.
Comment 9 Gerrit Notification Bot 2013-11-07 22:08:57 UTC 
Change 94256 had a related patch set uploaded by Bartosz Dziewoński:
Migrate usage of wikibits in legacy protect.js and upload.js

https://gerrit.wikimedia.org/r/94256
Comment 10 Gerrit Notification Bot 2013-11-07 22:23:27 UTC 
Change 94256 merged by jenkins-bot:
Migrate usage of wikibits in legacy protect.js and upload.js

https://gerrit.wikimedia.org/r/94256
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links